Skip to content

Diffusion coefficients are not preserved in the micm::Phase #845

@boulderdaze

Description

@boulderdaze

In the mechanism configuration, the PhaseSpecies struct is defined as follows. micm::Phase stores species as a std::vector<micm::Species>, instead std::vector<PhaseSpecies> and therefore, diffusion coefficient information for species in a given phase is not captured during the conversion from the mechanism configuration type to the micm type. This needs to be implemented.

From mechanism configuration

      struct PhaseSpecies
      {
        std::string name;
        std::optional<double> diffusion_coefficient;
        /// @brief Unknown properties, prefixed with two underscores (__)
        std::unordered_map<std::string, std::string> unknown_properties;
      };

      struct Phase
      {
        std::string name;
        std::vector<PhaseSpecies> species;
        /// @brief Unknown properties, prefixed with two underscores (__)
        std::unordered_map<std::string, std::string> unknown_properties;
      };

Acceptance criteria

Ideas

  • Update the micm::Phase class
  • Updates the test

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions