Skip to content

dev: nightly v0.13.15#1908

Merged
Myriad-Dreamin merged 21 commits intoMyriad-Dreamin:nightly/v0.13.15from
ParaN3xus:nightly-0.13.15
Jul 23, 2025
Merged

dev: nightly v0.13.15#1908
Myriad-Dreamin merged 21 commits intoMyriad-Dreamin:nightly/v0.13.15from
ParaN3xus:nightly-0.13.15

Conversation

@ParaN3xus
Copy link
Collaborator

@ParaN3xus
Copy link
Collaborator Author

Related issues: #1909, #1910, #1911

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LoCs of lock file increases from 6100+ to 6500+, we may check whether there are some diverged common dependencies.

fn push_color(&mut self, range: Range<usize>, color: Color) -> Option<()> {
let rng = self.ctx.to_lsp_range(range, &self.source);
let [r, g, b, a] = color.to_rgb().to_vec4();
let (r, g, b, a) = color.to_rgb().into_components();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: investigate to_vec4 is exact into_components

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

) -> Option<Definition> {
let label = Label::construct(name.into());
let sel = Selector::Label(label);
let sel = Selector::Label(label.unwrap());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: we unwrap here

let csl_style = bib_elem
.style
.get_ref(StyleChain::default())
.derived
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: is clone cheap?

typst_source: &Source,
) -> Option<usize> {
let lines = typst_source.len_lines() as u32;
let lines = typst_source.lines().len_lines() as u32;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could refactor to better utilize lines() apis.

{
"isIncomplete": false,
"items": [
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: set body?

let metadata = doc.introspector().query(&Selector::Label(selector));
let metadata = doc
.introspector()
.query(&Selector::Label(selector.unwrap()));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: we added unwrap here

let label = Label::new(PicoStr::intern("test-html-example"));
// todo: error multiple times
doc.introspector.query_label(label).is_ok()
doc.introspector.query_label(label.unwrap()).is_ok()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: added unwrap

World,
};

use crate::{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use crate::{ was moved forward occasionally.

@Myriad-Dreamin Myriad-Dreamin merged commit e3e680e into Myriad-Dreamin:nightly/v0.13.15 Jul 23, 2025
28 of 29 checks passed
@ParaN3xus ParaN3xus mentioned this pull request Jul 31, 2025
Myriad-Dreamin pushed a commit that referenced this pull request Jul 31, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Myriad-Dreamin pushed a commit that referenced this pull request Aug 2, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Myriad-Dreamin pushed a commit that referenced this pull request Aug 2, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Myriad-Dreamin pushed a commit that referenced this pull request Aug 2, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Myriad-Dreamin pushed a commit that referenced this pull request Aug 2, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Myriad-Dreamin pushed a commit that referenced this pull request Aug 2, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
ParaN3xus added a commit to ParaN3xus/tinymist that referenced this pull request Aug 7, 2025
In addition to the work from Myriad-Dreamin#1908, the following have been added:
- Attempted to fix the typlite issue, see Myriad-Dreamin#1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Myriad-Dreamin pushed a commit that referenced this pull request Sep 9, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
ParaN3xus added a commit to ParaN3xus/tinymist that referenced this pull request Sep 24, 2025
In addition to the work from Myriad-Dreamin#1908, the following have been added:
- Attempted to fix the typlite issue, see Myriad-Dreamin#1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Myriad-Dreamin pushed a commit that referenced this pull request Oct 21, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Myriad-Dreamin pushed a commit that referenced this pull request Oct 21, 2025
In addition to the work from #1908, the following have been added:
- Attempted to fix the typlite issue, see #1911
- Updated Rust toolchain to 1.88 to align with upstream Rust version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants