Skip to content

[BUGFIX] Allow order-insensitve removeDeclarationBlockBySelector #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverklee merged 2 commits into from
Dec 4, 2025
Merged

[BUGFIX] Allow order-insensitve removeDeclarationBlockBySelector #1406

oliverklee merged 2 commits into from
Dec 4, 2025

Conversation

@JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Dec 4, 2025 •
edited
Loading

Also internally avoid comparison with ==.

Resolves #1330

@JakeQZ JakeQZ self-assigned this Dec 4, 2025
@JakeQZ JakeQZ added cleanup refactor For PRs that refactor code without changing functionality labels Dec 4, 2025
@JakeQZ JakeQZ marked this pull request as draft December 4, 2025 01:13
@coveralls
Copy link

coveralls commented Dec 4, 2025 •
edited
Loading

Coverage Status

coverage: 62.706% (+0.2%) from 62.487%
when pulling 52cd175 on task/remove-remove-declaration-block-loose
into 51a3c0a on main.

@JakeQZ JakeQZ mentioned this pull request Dec 4, 2025
Closed
@JakeQZ JakeQZ force-pushed the task/remove-remove-declaration-block-loose branch from 2d27485 to 41605d1 Compare December 4, 2025 12:31
@JakeQZ
[BUGFIX] Allow order-insensitve removeDeclarationBlockBySelector
a57c942 
Also internally avoid comparison with `==`.

Resolves #1330
@JakeQZ JakeQZ changed the title [TASK] Lose loose comparison in removeDeclarationBlockBySelector [BUGFIX] Allow order-insensitve removeDeclarationBlockBySelector Dec 4, 2025
@JakeQZ JakeQZ marked this pull request as ready for review December 4, 2025 12:32
oliverklee
oliverklee reviewed Dec 4, 2025
View reviewed changes
@JakeQZ JakeQZ force-pushed the task/remove-remove-declaration-block-loose branch from 41605d1 to 52cd175 Compare December 4, 2025 16:08
@JakeQZ JakeQZ requested a review from oliverklee December 4, 2025 16:11
oliverklee
oliverklee approved these changes Dec 4, 2025
View reviewed changes
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oliverklee oliverklee merged commit dc99bbd into main Dec 4, 2025
23 checks passed
@oliverklee oliverklee deleted the task/remove-remove-declaration-block-loose branch December 4, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

cleanup refactor For PRs that refactor code without changing functionality

Projects

None yet

Milestone

9.2.0: New features, bug fixes and de...

Development

Successfully merging this pull request may close these issues.

Resolve loose comparison in removeDeclarationBlockBySelector()

4 participants

@JakeQZ @coveralls @oliverklee