doc: make upload target dependency on rsync optional#76
Merged
MaxKellermann merged 1 commit intoMusicPlayerDaemon:masterfrom Nov 30, 2021
nmeum:rsync-dep
Merged
doc: make upload target dependency on rsync optional#76MaxKellermann merged 1 commit intoMusicPlayerDaemon:masterfrom nmeum:rsync-dep
MaxKellermann merged 1 commit intoMusicPlayerDaemon:masterfrom
nmeum:rsync-dep
Conversation
Currently, rsync is an unconditional dependency and checked during `meson configure`. As such, the build will fail if rsync is not installed which is probably not what was intended here. From the meson documentation: Meson will automatically insert the appropriate dependencies on targets and files listed in this keyword [the command] argument. This commit fixes the unconditional dependency on rsync with an explicit find_program invocation with `required: false`. Also wrap the custom_target in an if statement since it is not allowed to use non-found external programs in `command`.
ncfavier
added a commit
to ncfavier/nixpkgs
that referenced
this pull request
Jan 22, 2022
Adds upstream patch from MusicPlayerDaemon/mpc#76 to make the dependency on rsync optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, rsync is an unconditional dependency and checked during
meson configure. As such, the build will fail if rsync is not installedwhich is probably not what was intended here.
From the meson documentation:
This commit fixes the unconditional dependency on rsync with an explicit
find_program invocation with
required: false. Also wrap thecustom_target in an if statement since it is not allowed to use
non-found external programs in
command.