Skip to content

Comments

Add Builds for Intel Macs#76

Merged
iamEvanYT merged 2 commits intomainfrom
evan/intel-mac-support
May 29, 2025
Merged

Add Builds for Intel Macs#76
iamEvanYT merged 2 commits intomainfrom
evan/intel-mac-support

Conversation

@iamEvanYT
Copy link
Member

@iamEvanYT iamEvanYT commented May 29, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated macOS build configuration to produce both DMG and ZIP packages with universal architecture support.
    • Configured Electron download to use a custom mirror URL for improved reliability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 29, 2025 •
edited
Loading

Warning

Rate limit exceeded

@iamEvanYT has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c59e202 and 3068dba.

📒 Files selected for processing (3)
  • .github/workflows/build-and-release.yml (3 hunks)
  • .github/workflows/build.yml (3 hunks)
  • electron-builder.json (1 hunks)

Walkthrough

The macOS build configuration in the electron-builder.json file was updated to specify two build targets: "dmg" and "zip", both set to create universal binaries. The notarization setting remains unchanged. Additionally, the Electron download configuration was changed from a path string to an object specifying a custom mirror URL.

Changes

File Change Summary
electron-builder.json Added "dmg" and "zip" as universal build targets for macOS; notarize flag unchanged; changed electron download config from path string to object with custom mirror URL.

Poem

Two targets now for Mac we see,
A DMG and ZIP, built universally.
Notarize stays false, no change in sight,
Packaging options set just right.
Electron fetches from a mirror new,
A hop ahead, with builds anew! 🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025 •
edited
Loading

Build artifacts for all platforms are ready! 🚀

Download the artifacts from:

(execution 15323737892 / attempt 1)

coderabbitai[bot]
coderabbitai bot reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
electron-builder.json (1)

76-85: Explicitly define macOS build targets
Adding the target array with dmg and zip universal builds covers both installer and portable formats and supports Intel and Apple Silicon in one binary. Consider whether you’d benefit from separate x64/arm64 builds (smaller downloads) or additional targets like pkg or mas for Mac App Store distribution.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc2c372 and 4ed99aa.

📒 Files selected for processing (1)
  • electron-builder.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build (ubuntu-24.04-arm)
  • GitHub Check: build (ubuntu-latest)
🔇 Additional comments (1)
electron-builder.json (1)

75-75: Confirm notarization setting placement and scope
The "notarize": false flag has been added under the mac section. Ensure this correctly disables notarization for both the dmg and zip artifacts as intended. If you need to control notarization per target (or globally), verify that electron-builder supports this placement.

@iamEvanYT iamEvanYT force-pushed the evan/intel-mac-support branch from 4ed99aa to c59e202 Compare May 29, 2025 12:16
@iamEvanYT iamEvanYT force-pushed the evan/intel-mac-support branch from c59e202 to 3068dba Compare May 29, 2025 12:22
@iamEvanYT iamEvanYT merged commit 1693b55 into main May 29, 2025
10 checks passed
@iamEvanYT iamEvanYT deleted the evan/intel-mac-support branch May 29, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iamEvanYT