Upgrade to Electron v36 by iamEvanYT · Pull Request #74 · MultiboxLabs/flow-browser

iamEvanYT · 2025-05-27T22:11:37Z

Info

Upgrade from v35.3.0 to v36.3.1

Best Case: Wait for a release from electron-vite for better compatability with new Node and Chromium versions.

Summary by CodeRabbit

Chores
- Updated the Electron package to a newer version for improved stability and performance.

coderabbitai · 2025-05-27T22:11:44Z

Walkthrough

The change updates the "electron" package version in the devDependencies section of package.json from v35.3.0+wvcus to v36.3.1+wvcus. It also modifies extension management calls in ExtensionManager to use the extensions property of the session object instead of direct session method calls. No exported or public entities were altered.

Changes

File(s)	Change Summary
package.json	Updated "electron" devDependency from v35.3.0+wvcus to v36.3.1+wvcus
src/main/modules/extensions/...	Refactored extension loading/unloading to use `session.extensions` namespace instead of direct session calls

Possibly related PRs

Bump Dependencies Versions #48: Updates dependency versions in package.json, including Electron-related dependencies.

Poem

A hop and a skip, a version ascends,
Electron now newer, as the changelog extends.
Extensions now nested, in sessions they play,
A cleaner approach hops into the day!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca04b8c and 624dc0d.

📒 Files selected for processing (1)

src/main/modules/extensions/management.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: build (windows-latest)
GitHub Check: build (macos-latest)
GitHub Check: build (ubuntu-latest)
GitHub Check: build (ubuntu-24.04-arm)

🔇 Additional comments (3)

src/main/modules/extensions/management.ts (3)

310-310: LGTM! Extension loading API updated correctly.

The change from session.loadExtension() to session.extensions.loadExtension() properly aligns with the Electron v36 API structure where extension methods are now namespaced under the extensions property.

325-325: LGTM! Extension retrieval API updated correctly.

The change from this.profileSession.getExtension() to this.profileSession.extensions.getExtension() correctly follows the new Electron v36 API structure.

330-330: LGTM! Extension removal API updated correctly.

The change from this.profileSession.removeExtension() to this.profileSession.extensions.removeExtension() correctly implements the new Electron v36 API structure.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-27T22:11:50Z

Build artifacts for all platforms are ready! 🚀

Download the artifacts from:

(execution 15323540919 / attempt 1)

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a69f0a7 and ca04b8c.

⛔ Files ignored due to path filters (1)

bun.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)
GitHub Check: build (ubuntu-24.04-arm)

package.json

iamEvanYT added 2 commits May 27, 2025 23:06

feat: update bun.lock & package.json

03178b8

fix: bun.lock

ca04b8c

coderabbitai bot reviewed May 27, 2025

View reviewed changes

package.json Show resolved Hide resolved

chore: replace deprecated extension methods

624dc0d

iamEvanYT merged commit 0337523 into main May 29, 2025
9 checks passed

iamEvanYT deleted the evan/upgrade-electron-36 branch May 29, 2025 13:06

coderabbitai bot mentioned this pull request Jun 9, 2025

Automatical Electron Upgrader #110

Merged

coderabbitai bot mentioned this pull request Jun 19, 2025

Settings Menu Updates #95

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Upgrade to Electron v36#74

Upgrade to Electron v36#74
iamEvanYT merged 3 commits intomainfrom
evan/upgrade-electron-36

iamEvanYT commented May 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 27, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented May 27, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

iamEvanYT commented May 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Info

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build artifacts for all platforms are ready! 🚀

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

iamEvanYT commented May 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented May 27, 2025 •

edited

Loading