electron/browser/window.ts (1)

76-77: User experience change: Windows now open maximized by default

This change makes all browser windows maximize immediately upon creation, which changes the default user experience. While this may enhance the Picture-in-Picture functionality, consider:

1. Is this behavior desirable for all users and scenarios?
2. Should this be a configurable setting rather than a hard-coded behavior?
3. Should the window size/state be persisted between sessions?

Consider making window maximization behavior configurable:

+ import { getSettings } from "@/saving/settings";

  constructor(browser: Browser, type: BrowserWindowType, options: BrowserWindowCreationOptions = {}) {
    // ...existing code...
    
    this.window = new BrowserWindow({
      // ...existing options...
    });

-   this.window.maximize();
+   // Maximize window based on settings or default behavior
+   getSettings().then(settings => {
+     if (settings.window?.startMaximized !== false) {
+       this.window.maximize();
+     }
+   }).catch(() => {
+     // Fall back to maximized if settings can't be loaded
+     this.window.maximize();
+   });

    // ...rest of constructor...
  }

electron/browser/tabs/tab-manager.ts (1)

193-207: Use optional‑chaining & minimal guard logic

The null‑check on tab can be simplified with optional‑chaining, which also satisfies the Biome useOptionalChain lint error flagged at this location.

-    const tab = this.getTabById(tabId);
-    if (tab && tab.isPictureInPicture) {
+    const tab = this.getTabById(tabId);
+    if (tab?.isPictureInPicture) {
       tab.isPictureInPicture = false;
       tab.emit("updated");

       this.setActiveTab(tab);

       return true;
     }
     return false;

Besides tidier code, this avoids accidentally dereferencing undefined if the method is called after the tab has been removed.

🧰 Tools

🪛 Biome (1.9.4)

[error] 198-198: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

electron/ipc/browser/tabs.ts (1)

170-173: browser?.tabs may still be undefined – add an extra optional‑chain

If, for any reason, the Browser instance exists but its tabs manager has not been initialised, the current code will attempt to read disablePictureInPicture on undefined and throw. A single character fixes the edge‑case:

-  const disabled = browser?.tabs.disablePictureInPicture(tabId);
+  const disabled = browser?.tabs?.disablePictureInPicture(tabId);

Returning false on failure (as you already do) is then guaranteed.

electron/browser/tabs/tab.ts (2)

100-104: Public flag added — consider initial sync on construction

isPictureInPicture defaults to false, but if the tab happens to load a page that is already in PiP before the first layout pass, the flag could be out‑of‑sync.
Not critical, yet initialising by interrogating document.pictureInPictureElement once after did-finish-load would make the state authoritative.

---

512-537: Exiting PiP: race‑condition & leakage of inline function

1. exitPiP is re‑created on every visibility change; extracting it to a const outside updateLayout (or to a private static) avoids needless re‑allocations.
2. Because executeJavaScript is asynchronous, the tab could flip visibility again before the promise settles, leaving isPictureInPicture briefly incorrect. Awaiting it (or storing a local visibleAtCallTime flag) would prevent the mismatch.

No functional bug today, but the above would make the state handling more robust.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro