fix: electron version updater by iamEvanYT · Pull Request #170 · MultiboxLabs/flow-browser

iamEvanYT · 2025-12-05T16:02:22Z

Summary by CodeRabbit

Documentation
- Updated Electron update workflow documentation with new procedures, including cache clearing and lock file adjustments.
Chores
- Updated Electron dependency resolution from git-based to HTTPS URL format.
- Modified internal update scripts to support new dependency URL handling and shortened commit hashes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-05T16:02:33Z

Walkthrough

This PR transitions Electron dependency resolution from git+ssh GitHub references to HTTPS URLs, introduces short-hash commit referencing in lock files, updates the electron-upgrader script to handle the new format, and expands manual update documentation with cache cleanup steps.

Changes

Cohort / File(s)	Summary
Documentation `docs/contributing/updating-electron.md`	Updated dependency URL templates from git-based format to HTTPS GitHub URLs, expanded manual update workflow with cache deletion and bun.lock adjustment steps using short commit hashes.
Configuration `package.json`	Changed Electron dependency reference from GitHub spec format to direct HTTPS URL while maintaining version tag.
Electron Upgrader `scripts/electron-upgrader/_modules/updater.ts`	Replaced git+ssh prefixes with HTTPS URLs, introduced `LOCK_PREFIX` and `LOCK_SUFFIX` constants for lock-file assembly, implemented 7-character short commit hash handling, and updated both `updatePackageJson` and `updateBunLock` functions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Verify consistency of HTTPS URL format across all three files
Validate short commit hash logic (7-character truncation) in updater.ts
Confirm lock-file prefix/suffix construction matches expected bun.lock format
Review documentation examples match updated URL patterns

Possibly related PRs

Automatical Electron Upgrader #110: Directly modifies the same electron-upgrader logic with HTTPS URLs and lock-file prefix/suffix/hash handling in updater.ts.
Add a way to use stock electron #67: Also modifies Electron dependency entries in package.json and bun.lock with different formatting approach.

Suggested reviewers

IAmStiven

Poem

🐰 A rabbit hops through URLs anew,
From git to https, a cleaner view!
Short hashes dance in lock-file grace,
Electron builds at swifter pace! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: electron version updater' directly addresses the main change: updates to the electron dependency resolver and version update workflow across package.json, bun.lock, and the updater script.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch evan/fix-electron-updater

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-05T16:02:34Z

Build artifacts for all platforms are ready! 🚀

Download the artifacts for:

One-line installer (Unstable):

bunx flow-debug-build --open 19968564165

(execution 19968564165 / attempt 1)

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94d63cc and b675932.

⛔ Files ignored due to path filters (1)

bun.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

docs/contributing/updating-electron.md (2 hunks)
package.json (1 hunks)
scripts/electron-upgrader/_modules/updater.ts (3 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

package.json

📄 CodeRabbit inference engine (.cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc)

package.json: Use bun install instead of npm install or yarn install or pnpm install
Use bun run <script> instead of npm run <script> or yarn run <script> or pnpm run <script>

Files:

package.json

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc)

**/*.{js,jsx,ts,tsx}: Use bun <file> instead of node <file> or ts-node <file>
Bun automatically loads .env, so don't use dotenv.
Use Bun.serve() for HTTP servers and WebSockets instead of express.
Use bun:sqlite for SQLite instead of better-sqlite3.
Use Bun.redis for Redis instead of ioredis.
Use Bun.sql for Postgres instead of pg or postgres.js.
Use built-in WebSocket instead of ws.
Prefer Bun.file over node:fs's readFile/writeFile.
Use Bun.$ for shell commands instead of execa.

Files:

scripts/electron-upgrader/_modules/updater.ts

**/*.{html,ts,css}

📄 CodeRabbit inference engine (.cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc)

Use bun build <file.html|file.ts|file.css> instead of webpack or esbuild

Files:

scripts/electron-upgrader/_modules/updater.ts

🧠 Learnings (7)