Skip to content

Comments

fix: drag & drop tabs ordering#132

Merged
iamEvanYT merged 1 commit intoMultiboxLabs:mainfrom
MHase:fix/tabs-drag-drop-order
Jun 23, 2025
Merged

fix: drag & drop tabs ordering#132
iamEvanYT merged 1 commit intoMultiboxLabs:mainfrom
MHase:fix/tabs-drag-drop-order

Conversation

@MHase
Copy link
Contributor

@MHase MHase commented Jun 19, 2025 •
edited by coderabbitai bot
Loading

This fix addresses a bug where a variable was accessed before it was properly initialized, which resulted in broken tab ordering functionality.

Summary by CodeRabbit

  • Bug Fixes
    • Improved the accuracy of tab group ordering when moving tabs in the sidebar.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 19, 2025 •
edited
Loading

Walkthrough

The change updates the logic within the moveTab callback in the space sidebar component. Specifically, it alters which array is used to determine the indices of tab groups during sorting, switching from a newly sorted array to the original array for index lookups.

Changes

File(s) Change Summary
src/renderer/src/components/browser-ui/sidebar/content/space-sidebar.tsx Modified the tab group sorting logic in the moveTab callback to reference the original array for index lookups.

Suggested reviewers

  • iamEvanYT

Poem

A hop, a skip, a tab moves right—
Sidebar logic shining bright.
Indices checked, arrays in line,
Sorting tabs is now just fine.
With every change, the code will gleam—
Hopping forward, swift and keen! 🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5cd6d8 and c566c92.

📒 Files selected for processing (1)
  • src/renderer/src/components/browser-ui/sidebar/content/space-sidebar.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: build (windows-latest)
  • GitHub Check: build (macos-13)
  • GitHub Check: build (macos-latest)
  • GitHub Check: build (ubuntu-24.04-arm)
🔇 Additional comments (1)
src/renderer/src/components/browser-ui/sidebar/content/space-sidebar.tsx (1)

110-111: LGTM! This correctly fixes the drag & drop initialization bug.

The fix addresses the core issue where newSortedTabGroups was being accessed inside its own sort comparator before the sorting operation completed. Using sortedTabGroups.findIndex() instead references the stable original array to get the correct current positions, ensuring reliable index lookups during the sort operation.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@iamEvanYT iamEvanYT merged commit dbac932 into MultiboxLabs:main Jun 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamEvanYT iamEvanYT iamEvanYT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MHase @iamEvanYT