Skip to content

Comments

feat: allow pinch zoom#129

Merged
iamEvanYT merged 1 commit intoMultiboxLabs:mainfrom
MHase:feat/pinch-in-zoom
Jun 18, 2025
Merged

feat: allow pinch zoom#129
iamEvanYT merged 1 commit intoMultiboxLabs:mainfrom
MHase:feat/pinch-in-zoom

Conversation

@MHase
Copy link
Contributor

@MHase MHase commented Jun 16, 2025 •
edited by coderabbitai bot
Loading

Introduces pinch-to-zoom functionality, commonly used on macOS trackpads

It enables webFrame.setVisualZoomLevelLimits to max 500% zoom.

Example:

Screen.Recording.2025-06-16.at.22.41.07.mp4

Summary by CodeRabbit

  • New Features
    • Zoom level for web content is now limited to a minimum of 1 and a maximum of 5 after loading, providing a consistent and controlled zoom experience.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 16, 2025 •
edited
Loading

Walkthrough

The update introduces an event listener in the Tab class that listens for the "did-finish-load" event on the webContents object. Upon this event, it sets the visual zoom level limits to a minimum of 1 and a maximum of 5, constraining the zoom range after web content loads.

Changes

File(s) Change Summary
src/main/browser/tabs/tab.ts Added a "did-finish-load" event listener to set visual zoom level limits (1-5) on webContents after content loads.

Poem

When a tab completes its load,
Zoom limits now are bestowed.
From one to five, you may see,
No more, no less—just as it should be.
A rabbit hops by, nodding with glee,
For browsing is now zoomed-in harmony! 🐇🔍

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/main/browser/tabs/tab.ts (1)

365-368: Add minimal error-handling for setVisualZoomLevelLimits

webContents.setVisualZoomLevelLimits() returns a Promise.
If (for example) the WebContents is destroyed during navigation the promise rejects, producing an unhandled-rejection warning in the main process. A terse catch keeps the log clean without bloating the code.

-  webContents.setVisualZoomLevelLimits(1, 5);
+  webContents
+    .setVisualZoomLevelLimits(1, 5)
+    .catch((err) => console.warn("Failed to set zoom limits:", err));

[nitpick]

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4840cea and 79547fc.

📒 Files selected for processing (1)
  • src/main/browser/tabs/tab.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: build (windows-latest)
  • GitHub Check: build (macos-latest)
  • GitHub Check: build (macos-13)
  • GitHub Check: build (ubuntu-24.04-arm)
  • GitHub Check: build (ubuntu-latest)

@iamEvanYT
Copy link
Member

iamEvanYT commented Jun 16, 2025

Awesome! Didn't know it can be enabled that way.

@iamEvanYT iamEvanYT merged commit c5cd6d8 into MultiboxLabs:main Jun 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@iamEvanYT iamEvanYT iamEvanYT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MHase @iamEvanYT