Reviewing files that changed from the base of the PR and between 7d08111 and 3836295.

• src/renderer/src/routes/about/config.tsx (1 hunks)
• src/renderer/src/routes/about/page.tsx (1 hunks)
• src/renderer/src/routes/about/route.tsx (1 hunks)
• src/renderer/src/routes/error/config.tsx (1 hunks)
• src/renderer/src/routes/error/page.tsx (1 hunks)
• src/renderer/src/routes/error/route.tsx (1 hunks)
• src/renderer/src/routes/extensions/config.tsx (1 hunks)
• src/renderer/src/routes/extensions/page.tsx (1 hunks)
• src/renderer/src/routes/extensions/route.tsx (1 hunks)
• src/renderer/src/routes/games/config.tsx (1 hunks)
• src/renderer/src/routes/games/page.tsx (1 hunks)
• src/renderer/src/routes/games/route.tsx (1 hunks)
• src/renderer/src/routes/main-ui/config.tsx (1 hunks)
• src/renderer/src/routes/main-ui/page.tsx (1 hunks)
• src/renderer/src/routes/main-ui/route.tsx (1 hunks)
• src/renderer/src/routes/new-tab/config.tsx (1 hunks)
• src/renderer/src/routes/new-tab/page.tsx (1 hunks)
• src/renderer/src/routes/new-tab/route.tsx (1 hunks)
• src/renderer/src/routes/omnibox-debug/config.tsx (1 hunks)
• src/renderer/src/routes/omnibox-debug/page.tsx (1 hunks)
• src/renderer/src/routes/omnibox-debug/route.tsx (1 hunks)
• src/renderer/src/routes/omnibox/config.tsx (1 hunks)
• src/renderer/src/routes/omnibox/page.tsx (1 hunks)
• src/renderer/src/routes/omnibox/route.tsx (1 hunks)
• src/renderer/src/routes/onboarding/config.tsx (1 hunks)
• src/renderer/src/routes/onboarding/page.tsx (1 hunks)
• src/renderer/src/routes/onboarding/route.tsx (1 hunks)
• src/renderer/src/routes/pdf-viewer/config.tsx (1 hunks)
• src/renderer/src/routes/pdf-viewer/page.tsx (1 hunks)
• src/renderer/src/routes/pdf-viewer/route.tsx (1 hunks)
• src/renderer/src/routes/popup-ui/config.tsx (1 hunks)
• src/renderer/src/routes/popup-ui/page.tsx (1 hunks)
• src/renderer/src/routes/popup-ui/route.tsx (1 hunks)
• src/renderer/src/routes/settings/config.tsx (1 hunks)
• src/renderer/src/routes/settings/page.tsx (1 hunks)
• src/renderer/src/routes/settings/route.tsx (1 hunks)

• GitHub Check: build (windows-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: build (macos-13)
• GitHub Check: build (ubuntu-24.04-arm)

src/renderer/src/routes/games/config.tsx (1)

1-6: LGTM! Consistent implementation following established patterns.

The RouteProviders component correctly follows the established pattern across other routes, properly wrapping children with ThemeProvider and forcing the dark theme. This centralizes theme configuration at the route level as intended.

src/renderer/src/routes/games/page.tsx (1)

141-148: LGTM! Correctly delegates theming to route level.

The removal of ThemeProvider from the App component is appropriate since theming is now handled by the RouteProviders component at the route level. This simplifies the page component and follows the established refactor pattern.

src/renderer/src/routes/games/route.tsx (1)

1-14: LGTM! Proper implementation of React lazy loading.

The refactor correctly replaces manual dynamic imports with React's lazy and Suspense, following the established pattern across other routes. The integration with RouteProviders properly centralizes theme configuration.

src/renderer/src/routes/main-ui/config.tsx (1)

3-5: LGTM! Consistent with the established pattern.

The RouteProviders component correctly follows the same passthrough pattern as popup-ui/config.tsx (lines 3-5). This maintains consistency across routes while allowing for future provider extensions if needed for the main UI.

src/renderer/src/routes/main-ui/page.tsx (1)

7-7: LGTM! Good simplification removing unnecessary wrapper.

Directly exporting the Page component eliminates the redundant intermediate App component, improving code clarity while maintaining the same functionality.

src/renderer/src/routes/main-ui/route.tsx (2)

1-2: LGTM! Excellent refactor to use React's lazy loading.

The import of lazy and Suspense from React and the RouteProviders from the local config follows the established pattern and replaces manual dynamic imports with React's built-in lazy loading capabilities.

---

4-4: LGTM! Proper use of React.lazy for code splitting.

Using React.lazy with dynamic import is the recommended approach for code splitting and lazy loading components.

src/renderer/src/routes/extensions/page.tsx (1)

188-193: LGTM: Theme provider successfully moved to RouteProviders.

The removal of ThemeProvider from the App component is correct as theming is now centralized in the RouteProviders component from config.tsx. This eliminates duplication and follows the established pattern across other routes.

src/renderer/src/routes/extensions/config.tsx (1)

1-6: LGTM: RouteProviders correctly centralizes theme management.

The RouteProviders component properly encapsulates theme configuration with forceTheme="dark", maintaining the same dark theme behavior that was previously applied in the page component. This pattern is consistent with other route configurations like src/renderer/src/routes/about/config.tsx and src/renderer/src/routes/games/config.tsx.

src/renderer/src/routes/extensions/route.tsx (2)

1-4: LGTM: Proper lazy loading implementation.

The migration from manual dynamic imports to React's lazy() function is well-implemented and follows React best practices for code splitting.

---

6-14: LGTM: RouteProviders integration follows established pattern.

The integration of RouteProviders wrapper ensures consistent theming and matches the pattern established in other routes like src/renderer/src/routes/about/route.tsx.

src/renderer/src/routes/settings/config.tsx (1)

1-6: LGTM! Clean provider pattern implementation.

The RouteProviders component correctly centralizes theming context for the settings route. The implementation is consistent with the broader refactor pattern across the application.

Note: Unlike some other routes (e.g., about, extensions use forceTheme="dark", and new-tab uses persist), this route uses the default ThemeProvider without additional props, which appears appropriate for a settings page that should respect user theme preferences.

src/renderer/src/routes/settings/page.tsx (1)

7-7: Excellent separation of concerns.

Directly exporting the Page component simplifies the architecture by removing theming responsibilities from the page level. The theming context is now properly handled by the RouteProviders component at the route level, improving maintainability and consistency.

src/renderer/src/routes/settings/route.tsx (1)

1-4: Excellent migration to React's built-in lazy loading.

The replacement of manual dynamic imports with React.lazy() is a significant improvement that leverages React's optimized code-splitting capabilities. The lazy import syntax is correct and follows React best practices.

src/renderer/src/routes/omnibox-debug/config.tsx (1)

1-6: Well-implemented provider centralization pattern.

The RouteProviders component effectively centralizes theming context at the route level, which aligns perfectly with the PR objectives. The implementation is clean, properly typed, and follows React best practices for provider composition.

src/renderer/src/routes/omnibox-debug/page.tsx (1)

435-440: Good separation of concerns by removing ThemeProvider from page level.

The change from wrapping content in ThemeProvider to using a React fragment is correct. The theming context is now properly handled at the route level through RouteProviders, which improves the separation of concerns and follows the intended architectural pattern.

src/renderer/src/routes/omnibox-debug/route.tsx (1)

1-14: Excellent implementation of React's lazy loading pattern.

The refactor successfully replaces manual dynamic imports with React's built-in lazy() and Suspense. The integration with RouteProviders properly centralizes the theming context at the route level.

src/renderer/src/routes/onboarding/page.tsx (1)

14-16: LGTM! Clean separation of concerns.

The removal of ThemeProvider from the App component properly delegates theming responsibility to the RouteProviders component at the route level, eliminating duplication and improving maintainability.

src/renderer/src/routes/onboarding/config.tsx (1)

1-6: LGTM! Consistent with established pattern.

The RouteProviders component correctly follows the established pattern across other route modules, properly wrapping children with ThemeProvider and enforcing the dark theme for the onboarding route.

src/renderer/src/routes/onboarding/route.tsx (2)

1-4: LGTM! Excellent refactor to React's built-in lazy loading.

The transition from manual dynamic imports to React.lazy is a great improvement that removes anti-patterns and leverages React's native code-splitting capabilities.

---

8-12: Well-integrated RouteProviders pattern.

The integration of RouteProviders correctly centralizes the theming logic and maintains consistency with the broader refactoring pattern across route modules.

src/renderer/src/routes/new-tab/config.tsx (1)

1-6: LGTM! Clean provider abstraction.

The RouteProviders component properly centralizes the theming logic for this route. The implementation is clean and follows React best practices with proper typing.

src/renderer/src/routes/new-tab/page.tsx (1)

9-12: Good simplification.

Removing the ThemeProvider wrapper from the page component and using a fragment is the right approach, as theming is now handled centrally by RouteProviders at the route level.

src/renderer/src/routes/new-tab/route.tsx (1)

1-14: Excellent refactor to React.lazy and Suspense.

The migration from manual dynamic imports and state management to React's built-in lazy loading is a significant improvement. The pattern is consistent with other routes and provides better code organization.

src/renderer/src/routes/pdf-viewer/config.tsx (1)

7-11: LGTM! Clean conditional provider pattern.

The conditional provider implementation is well-structured and follows React best practices. This pattern allows for flexible theme handling while maintaining a consistent interface.

src/renderer/src/routes/pdf-viewer/page.tsx (1)

21-21: LGTM! Simplified export aligns with refactor pattern.

The direct export of the Page component is consistent with the broader refactor that moves theme provider logic to the RouteProviders component in config.tsx. This simplification improves maintainability.

src/renderer/src/routes/pdf-viewer/route.tsx (2)

1-4: LGTM! Excellent use of React.lazy for code splitting.

The migration from manual dynamic imports to React's built-in lazy function is a great improvement. This approach is more declarative and integrates better with React's concurrent features.

---

6-14: LGTM! Clean integration of RouteProviders pattern.

The wrapping with RouteProviders is consistent with the broader refactor across routes and properly centralizes provider logic outside the page component.

src/renderer/src/routes/about/page.tsx (1)

50-53: LGTM! Clean separation of concerns achieved.

The removal of ThemeProvider from the page component and its replacement with a simple fragment correctly implements the refactor pattern. Theme context is now properly centralized in the RouteProviders component defined in config.tsx.

src/renderer/src/routes/about/config.tsx (1)

1-6: LGTM! Consistent implementation of the RouteProviders pattern.

The RouteProviders component correctly follows the established pattern seen across other routes (extensions, games, onboarding). Properly typed with ReactNode and enforces dark theme consistently with the forceTheme="dark" prop.

src/renderer/src/routes/about/route.tsx (2)

1-4: LGTM! Proper adoption of React's lazy loading.

The refactor correctly replaces manual dynamic imports with React's built-in lazy() function and imports the centralized RouteProviders from the config file. This follows React best practices for code splitting.

---

6-14: Excellent implementation of the new lazy loading pattern.

The route component successfully integrates:

• React's lazy and Suspense for declarative code splitting
• RouteProviders wrapper for centralized theme context
• Clean, readable structure that follows the established pattern

This refactor eliminates anti-patterns and adopts React best practices as intended by the PR objectives.

src/renderer/src/routes/omnibox/page.tsx (1)

7-7: LGTM: Clean simplification of page export.

The direct export of the Page component aligns well with the architectural improvement. Moving the ThemeProvider responsibility to the route level (via RouteProviders) creates a cleaner separation of concerns.

src/renderer/src/routes/omnibox/config.tsx (1)

1-6: LGTM: Consistent implementation of RouteProviders pattern.

The RouteProviders component correctly follows the established pattern across the codebase. Using a plain ThemeProvider without additional props is appropriate for the omnibox route, consistent with similar routes like error and settings as shown in the relevant code snippets.

src/renderer/src/routes/popup-ui/page.tsx (1)

7-7: LGTM! Clean simplification of the export.

Removing the intermediate App wrapper component and directly exporting the Page component eliminates unnecessary indirection and aligns with the broader refactor pattern.

src/renderer/src/routes/popup-ui/route.tsx (2)

1-4: LGTM! Proper implementation of React lazy loading.

The transition from manual dynamic imports to React's lazy() function is correctly implemented and follows React best practices for code-splitting.

---

6-14:

Details

✅ Verification successful

Verify consistent implementation across other routes.

The lazy loading pattern with RouteProviders wrapper looks good. Please ensure this pattern is consistently applied across all route files mentioned in the PR summary to maintain uniformity.

---

🏁 Script executed:

#!/bin/bash
# Description: Verify consistent lazy loading implementation across route files
# Expected: All route.tsx files should use lazy() and Suspense pattern

echo "=== Checking route.tsx files for lazy loading pattern ==="
fd -name "route.tsx" -t f -E node_modules | head -10 | xargs -I {} sh -c 'echo "=== {} ===" && cat {}'

echo -e "\n=== Checking for remaining manual dynamic imports in routes ==="
rg "import\(" src/renderer/src/routes/ -A 2 -B 2

Length of output: 4834

---

🏁 Script executed:

#!/bin/bash
# Verify that every route.tsx uses both <Suspense> and <RouteProviders> wrappers

echo "=== Checking Suspense usage in all route.tsx files ==="
find src/renderer/src/routes -type f -name route.tsx | while read file; do
  rg "<Suspense" -q "$file" || echo "Missing <Suspense> in $file"
done

echo ""
echo "=== Checking RouteProviders usage in all route.tsx files ==="
find src/renderer/src/routes -type f -name route.tsx | while read file; do
  rg "RouteProviders" -q "$file" || echo "Missing RouteProviders in $file"
done

Length of output: 2228

---

Consistent lazy-loading verified across all route files

All route.tsx under src/renderer/src/routes uniformly use:

• const PageComponent = lazy(() => import("./page"))
• <RouteProviders> wrapper
• <Suspense> fallback

No further changes needed—LGTM.

src/renderer/src/routes/error/config.tsx (1)

1-6: LGTM! Clean and consistent implementation.

The RouteProviders component follows the established pattern seen across other routes in the codebase. The implementation correctly wraps children with ThemeProvider and uses proper TypeScript typing.

src/renderer/src/routes/error/page.tsx (1)

154-154: Good refactor - simplified export structure.

Directly exporting the Page component aligns well with the new architecture where provider logic is centralized in the RouteProviders component. This removes unnecessary wrapper indirection.

src/renderer/src/routes/error/route.tsx (2)

1-4: Excellent use of React's built-in lazy loading.

The refactor from manual dynamic imports to React.lazy() is a great improvement that leverages React's optimized lazy loading capabilities.

---

7-13: Clean architecture with proper provider wrapping.

The structure correctly wraps the lazy-loaded component with RouteProviders to provide theming context, following the established pattern across other routes in the codebase.

Reviewing files that changed from the base of the PR and between 3836295 and 95bebee.

• src/renderer/src/routes/about/config.tsx (1 hunks)
• src/renderer/src/routes/about/route.tsx (1 hunks)
• src/renderer/src/routes/error/config.tsx (1 hunks)
• src/renderer/src/routes/error/route.tsx (1 hunks)
• src/renderer/src/routes/extensions/config.tsx (1 hunks)
• src/renderer/src/routes/extensions/route.tsx (1 hunks)
• src/renderer/src/routes/games/config.tsx (1 hunks)
• src/renderer/src/routes/games/route.tsx (1 hunks)
• src/renderer/src/routes/main-ui/config.tsx (1 hunks)
• src/renderer/src/routes/main-ui/route.tsx (1 hunks)
• src/renderer/src/routes/new-tab/config.tsx (1 hunks)
• src/renderer/src/routes/new-tab/route.tsx (1 hunks)
• src/renderer/src/routes/omnibox-debug/config.tsx (1 hunks)
• src/renderer/src/routes/omnibox-debug/route.tsx (1 hunks)
• src/renderer/src/routes/omnibox/config.tsx (1 hunks)
• src/renderer/src/routes/omnibox/route.tsx (1 hunks)
• src/renderer/src/routes/onboarding/config.tsx (1 hunks)
• src/renderer/src/routes/onboarding/route.tsx (1 hunks)
• src/renderer/src/routes/pdf-viewer/config.tsx (1 hunks)
• src/renderer/src/routes/pdf-viewer/route.tsx (1 hunks)
• src/renderer/src/routes/popup-ui/config.tsx (1 hunks)
• src/renderer/src/routes/popup-ui/route.tsx (1 hunks)
• src/renderer/src/routes/settings/config.tsx (1 hunks)
• src/renderer/src/routes/settings/route.tsx (1 hunks)
• src/renderer/src/types/routes.ts (1 hunks)

• src/renderer/src/types/routes.ts

• src/renderer/src/routes/popup-ui/route.tsx
• src/renderer/src/routes/main-ui/route.tsx
• src/renderer/src/routes/pdf-viewer/route.tsx
• src/renderer/src/routes/about/route.tsx
• src/renderer/src/routes/settings/route.tsx
• src/renderer/src/routes/new-tab/route.tsx
• src/renderer/src/routes/onboarding/route.tsx
• src/renderer/src/routes/error/route.tsx
• src/renderer/src/routes/extensions/route.tsx
• src/renderer/src/routes/omnibox/route.tsx
• src/renderer/src/routes/games/route.tsx
• src/renderer/src/routes/omnibox-debug/route.tsx

• GitHub Check: build (windows-latest)
• GitHub Check: build (ubuntu-24.04-arm)
• GitHub Check: build (ubuntu-latest)

src/renderer/src/routes/extensions/config.tsx (1)

1-2: LGTM: Imports are clean and appropriate.

The imports are correctly structured, importing the local ThemeProvider component and React's ReactNode type for proper TypeScript support.

src/renderer/src/routes/main-ui/config.tsx (2)

1-2: LGTM: Clean import structure.

The import statement correctly brings in ReactNode for proper TypeScript typing of the children prop.

---

3-8: LGTM: Consistent implementation following established patterns.

The RouteConfig implementation correctly follows the interface defined in src/renderer/src/types/routes.ts and is consistent with the pattern used in src/renderer/src/routes/popup-ui/config.tsx. The pass-through Providers component is appropriate for the main-ui route, which apparently doesn't require additional context providers like ThemeProvider used in other routes.

This implementation supports the PR's objective of standardizing route configuration for improved lazy loading.

src/renderer/src/routes/omnibox-debug/config.tsx (1)

1-2: LGTM: Imports are clean and appropriate.

The imports correctly bring in the necessary dependencies for the route configuration pattern.

src/renderer/src/routes/new-tab/config.tsx (1)

1-2: Imports look correct and minimal.

The imports are appropriate for the RouteConfig implementation - ThemeProvider for context provision and ReactNode for TypeScript typing.

src/renderer/src/routes/popup-ui/config.tsx (2)

1-2: LGTM! Clean import statement.

The import is appropriate and necessary for typing the children prop in the Providers component.

---

3-8: LGTM! Appropriate minimal config for popup-ui.

The RouteConfig implementation correctly follows the established pattern and is well-suited for popup-ui:

• Properly typed Providers component that acts as a passthrough
• Conforms to the RouteConfig interface from types/routes.ts
• The minimal setup (no additional providers, null fallback) is appropriate for popup UI components that typically don't require complex theming or context wrapping
• Consistent with the broader lazy loading refactor objectives

src/renderer/src/routes/pdf-viewer/config.tsx (1)

9-14: LGTM! Follows the established RouteConfig pattern.

The implementation correctly adheres to the RouteConfig interface and maintains consistency with other route configurations across the codebase.

src/renderer/src/routes/onboarding/config.tsx (1)

1-9: Excellent implementation of the RouteConfig pattern!

This follows the established pattern consistently with other routes. The use of forceTheme="dark" for onboarding makes sense from a UX perspective, ensuring a consistent dark theme during the user setup flow.

src/renderer/src/routes/settings/config.tsx (1)

1-2: LGTM! Clean and appropriate imports.

The imports follow the established pattern across other route configurations and properly import the necessary dependencies.

src/renderer/src/routes/games/config.tsx (1)

4-9: Excellent implementation of the new route configuration pattern!

This RouteConfig structure effectively implements the improved lazy loading approach mentioned in the PR objectives. The pattern of separating provider configuration from route components enhances modularity.

Reviewing files that changed from the base of the PR and between 19bdc7a and 8dcc18f.

• src/main/browser/window.ts (4 hunks)

• GitHub Check: build (macos-13)
• GitHub Check: build (windows-latest)
• GitHub Check: build (macos-latest)
• GitHub Check: build (ubuntu-24.04-arm)
• GitHub Check: build (ubuntu-latest)

src/main/browser/window.ts (3)

15-15: LGTM!

The import is correctly added to support the debug logging functionality in the new setupWindowShow method.

---

70-70: LGTM!

Setting show: false is the correct approach to prevent the window from appearing immediately upon creation, allowing the new controlled showing mechanism to manage when the window becomes visible.

---

92-93: LGTM!

The comment clearly explains the new approach and the method call properly delegates the window showing logic to the dedicated method.