Skip to content

Sidebar when in floating mode can never be set back to normal sidebar mode #86

@mikr13

Description

@mikr13

Describe the bug
When sidebar is set to floating mode & sidebarCollapseMode is offcanvas then the open button on the sidebar doesn't work. It won't set the sidebar back from floating mode to normal sidebar mode.

To Reproduce
Steps to reproduce the behavior:

  1. Go to settings
  2. Select Off Screen in Sidebar Collapse Mode dropdown under sidebar settings
  3. Close sidebar
  4. Hover on the side of the screen for sidebar to appear
  5. Click on open button
  6. Closes the sidebar & doesn't set the sidebar to normal sidebar more instead keeps it in floating mode

Expected behavior
Should set the sidebar in normal sidebar mode

Screenshots

Screen.Recording.2025-06-01.at.12.08.14_720.mov

Device Information:

  • OS: MacOS
  • App Version: 0.8.1

Additional context
Love the work, really awesome browser & clean code. I showed it to my mom & she loved it! ❤️

Now, I tried fixing it but it would require me to change the hover handling logic.
This particular code snippet is what's causing the reset even if I change the open button handler to set the sidebar variant back to sidebar. I'm not sure how you'd like to handle it so I left it untouched. I was thinking in terms of having another state in useSidebar but would like to discuss.

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsidebarIssues related to the sidebar

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions