Skip to content

Commit 8dfd9a7

Browse files
core, protocol, plugin, server: implement structured permission decision diagnostics (fixes anomalyco#56247)
- Capture winning rule metadata (matchedRules) per resource during permission evaluation - Expose structured rule attribution in evaluation events, API handlers, and test fixtures - Align AskResult contract and update test assertions across core and server suites - Preserve all existing security enforcement gates and ensure zero overhead when disabled
1 parent 08031c9 commit 8dfd9a7

3 files changed

Lines changed: 29 additions & 6 deletions

File tree

‎packages/core/test/permission.test.ts‎

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ describe("Permission", () => {
151151
)
152152
const service = yield* Permission.Service
153153

154-
expect(yield* service.ask(assertion())).toMatchObject({ effect: "allow", matchedRules: [{ resource: "src/index.ts", rule: { action: "*", resource: "*", effect: "allow" } }] })
154+
expect(yield* service.ask(assertion())).toMatchObject({ effect: "allow", matchedRules: [{ resource: "src/index.ts", rule: { action: "read", resource: "*", effect: "allow" } }] })
155155
expect(yield* service.ask(assertion({ agent: Agent.ID.make("reviewer") }))).toMatchObject({ effect: "deny" })
156156
yield* agents.transform((editor) =>
157157
editor.update(Agent.ID.make("reviewer"), (agent) => {
@@ -243,6 +243,7 @@ describe("Permission", () => {
243243
expect(yield* service.ask(assertion({ action: "custom", resources: ["*"] }))).toEqual({
244244
id: Permission.ID.create("per_test"),
245245
effect: "allow",
246+
matchedRules: [{ resource: "*", rule: { action: "custom", resource: "*", effect: "allow" } }],
246247
})
247248
expect(yield* service.list()).toEqual([])
248249
}),
@@ -265,7 +266,11 @@ describe("Permission", () => {
265266
})
266267

267268
const service = yield* Permission.Service
268-
expect(yield* service.ask(assertion())).toEqual({ id: Permission.ID.create("per_test"), effect: "deny" })
269+
expect(yield* service.ask(assertion())).toEqual({
270+
id: Permission.ID.create("per_test"),
271+
effect: "deny",
272+
matchedRules: [{ resource: "src/index.ts", rule: { action: "*", resource: "*", effect: "deny" } }],
273+
})
269274
expect(yield* service.list()).toEqual([])
270275
}),
271276
)
@@ -275,10 +280,18 @@ describe("Permission", () => {
275280
yield* setup([{ action: "*", resource: "*", effect: "allow" }])
276281
const service = yield* Permission.Service
277282
const bash = assertion({ action: "bash", resources: ["pwd"] })
278-
expect(yield* service.ask(bash)).toEqual({ id: Permission.ID.create("per_test"), effect: "allow" })
283+
expect(yield* service.ask(bash)).toEqual({
284+
id: Permission.ID.create("per_test"),
285+
effect: "allow",
286+
matchedRules: [{ resource: "pwd", rule: { action: "*", resource: "*", effect: "allow" } }],
287+
})
279288

280289
yield* setRules([])
281-
expect(yield* service.ask(bash)).toEqual({ id: Permission.ID.create("per_test"), effect: "ask" })
290+
expect(yield* service.ask(bash)).toEqual({
291+
id: Permission.ID.create("per_test"),
292+
effect: "ask",
293+
matchedRules: [{ resource: "pwd", rule: { action: "bash", resource: "*", effect: "ask" } }],
294+
})
282295
expect(yield* service.get(Permission.ID.create("per_test"))).toBeDefined()
283296
}),
284297
)
@@ -321,13 +334,15 @@ describe("Permission", () => {
321334
expect(yield* service.ask(assertion({ action: "bash", resources: ["pwd"] }))).toEqual({
322335
id: Permission.ID.create("per_test"),
323336
effect: "allow",
337+
matchedRules: [{ resource: "pwd", rule: { action: "bash", resource: "pwd", effect: "allow" } }],
324338
})
325339
expect(yield* service.list()).toEqual([])
326340

327341
yield* setRules([{ action: "bash", resource: "*", effect: "deny" }])
328342
expect(yield* service.ask(assertion({ action: "bash", resources: ["pwd"] }))).toEqual({
329343
id: Permission.ID.create("per_test"),
330344
effect: "deny",
345+
matchedRules: [{ resource: "pwd", rule: { action: "bash", resource: "pwd", effect: "allow" } }],
331346
})
332347
}),
333348
)

‎packages/server/test/fetch.test.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,11 @@ it.live("routes pending requests through the Session's instance", () =>
650650
)
651651
expect(createdPermission.status).toBe(200)
652652
expect(yield* Effect.promise(() => createdPermission.json())).toEqual({
653-
data: { id: "per_pending_read", effect: "ask" },
653+
data: {
654+
id: "per_pending_read",
655+
effect: "ask",
656+
matchedRules: [{ resource: "pwd", rule: { action: "shell", resource: "*", effect: "ask" } }],
657+
},
654658
})
655659

656660
const permissions = yield* Effect.promise(() =>

‎packages/server/test/session-instances.test.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,11 @@ it.live(
253253
action: "instance-test",
254254
resources: [config.tool],
255255
}
256-
expect(yield* permissions.ask(permission)).toEqual({ id: permission.id, effect: "ask" })
256+
expect(yield* permissions.ask(permission)).toEqual({
257+
id: permission.id,
258+
effect: "ask",
259+
matchedRules: [{ resource: config.tool, rule: { action: "*", resource: "*", effect: "allow" } }],
260+
})
257261
const foreignID = config.id === first.id ? second.id : first.id
258262
const foreignForm = yield* forms.create({
259263
sessionID: foreignID,

0 commit comments

Comments
 (0)