Skip to content

JsEvent: Make implementation internal & add xmldoc.#9996

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:jsevent_improve
Oct 12, 2024
Merged

JsEvent: Make implementation internal & add xmldoc.#9996
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:jsevent_improve

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 12, 2024

Description

Make JsEvent internal implementation to align with other services.
Added xmldoc.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 12, 2024
@codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (28bc599) to head (6ac3947).
Report is 555 commits behind head on dev.

Files with missing lines Patch % Lines
src/MudBlazor/Services/JsEvent/JsEvent.cs 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9996      +/-   ##
==========================================
+ Coverage   89.82%   90.96%   +1.13%     
==========================================
  Files         412      407       -5     
  Lines       11878    12593     +715     
  Branches     2364     2451      +87     
==========================================
+ Hits        10670    11455     +785     
+ Misses        681      581     -100     
- Partials      527      557      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro mentioned this pull request Oct 12, 2024
Closed
@ScarletKuro
Copy link
Member Author

ScarletKuro commented Oct 12, 2024

Added to v8.0.0 Migration Guide #9953

@ScarletKuro ScarletKuro merged commit d863a50 into MudBlazor:dev Oct 12, 2024
@ScarletKuro ScarletKuro deleted the jsevent_improve branch October 12, 2024 19:38
@ScarletKuro ScarletKuro added the v8 label Oct 12, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
@ScarletKuro @LLauter
JsEvent: Make implementation internal & add xmldoc. (MudBlazor#9996)
2d3769f
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Closed
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Closed
This was referenced Oct 5, 2025
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Nov 3, 2025
Merged
@dependabot dependabot bot mentioned this pull request Nov 12, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jan 3, 2026
Closed
@dependabot dependabot bot mentioned this pull request Jan 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change This change will require consumer code updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScarletKuro