Skip to content

KeyInterceptorService: Improve DisposeAsync#9992

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:ketintercept_improve
Oct 12, 2024
Merged

KeyInterceptorService: Improve DisposeAsync#9992
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:ketintercept_improve

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 12, 2024

Description

Can now finally use await for _keyInterceptorInterop.Disconnect.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro changed the title KeyInterceptorService: Improve DisposeAsyncCore KeyInterceptorService: Improve DisposeAsync Oct 12, 2024
@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Oct 12, 2024
@codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (28bc599) to head (67c3cf3).
Report is 552 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9992      +/-   ##
==========================================
+ Coverage   89.82%   90.96%   +1.13%     
==========================================
  Files         412      407       -5     
  Lines       11878    12579     +701     
  Branches     2364     2445      +81     
==========================================
+ Hits        10670    11443     +773     
+ Misses        681      580     -101     
- Partials      527      556      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 3356782 into MudBlazor:dev Oct 12, 2024
@ScarletKuro ScarletKuro deleted the ketintercept_improve branch October 12, 2024 17:45
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
@ScarletKuro @LLauter
KeyInterceptorService: Improve DisposeAsync (MudBlazor#9992)
2c7857e
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScarletKuro