Skip to content

StringExtensions: Remove not used API & add tests#9984

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:StringExtensions_cleanup
Oct 12, 2024
Merged

StringExtensions: Remove not used API & add tests#9984
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:StringExtensions_cleanup

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 12, 2024 •
edited
Loading

Description

Remove:

  • ToJsString
  • GetByteValue
  • IsNonEmpty

As it's not used in our codebase. Since StringExtensions is internal it's not a breaking change, so we can remove what we do not need.

How Has This Been Tested?

Added unit tests as this file had a poor coverage.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added docs Updates/improvements to project documentation that do not affect core library logic PR: needs review labels Oct 12, 2024
@ScarletKuro ScarletKuro added refactor Reorganizes code and has no changes to the API or functionality in the main library tests Updating tests or test infrastructure is the primary focus and there are no changes the main library and removed docs Updates/improvements to project documentation that do not affect core library logic PR: needs review labels Oct 12, 2024
@codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (28bc599) to head (17c7c40).
Report is 547 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9984      +/-   ##
==========================================
+ Coverage   89.82%   90.83%   +1.00%     
==========================================
  Files         412      407       -5     
  Lines       11878    12597     +719     
  Branches     2364     2453      +89     
==========================================
+ Hits        10670    11443     +773     
+ Misses        681      594      -87     
- Partials      527      560      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 8537cb7 into MudBlazor:dev Oct 12, 2024
@ScarletKuro ScarletKuro deleted the StringExtensions_cleanup branch October 12, 2024 12:47
@ScarletKuro ScarletKuro added docs Updates/improvements to project documentation that do not affect core library logic and removed docs Updates/improvements to project documentation that do not affect core library logic tests Updating tests or test infrastructure is the primary focus and there are no changes the main library labels Oct 12, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
@ScarletKuro @LLauter
StringExtensions: Remove not used API & add tests (MudBlazor#9984)
067be59
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactor Reorganizes code and has no changes to the API or functionality in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScarletKuro