Skip to content

DialogService: Remove obsolete OnDialogInstanceAdded#9980

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:dialog_deprecate
Oct 12, 2024
Merged

DialogService: Remove obsolete OnDialogInstanceAdded#9980
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:dialog_deprecate

Conversation

@ScarletKuro
Copy link
Member

Description

Remove deprecated API in DialogService

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Oct 12, 2024
@ScarletKuro
Copy link
Member Author

Added to v8.0.0 Migration Guide #9953

@codecov
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (28bc599) to head (a278113).
Report is 544 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9980      +/-   ##
==========================================
+ Coverage   89.82%   90.78%   +0.95%     
==========================================
  Files         412      406       -6     
  Lines       11878    12581     +703     
  Branches     2364     2453      +89     
==========================================
+ Hits        10670    11422     +752     
+ Misses        681      598      -83     
- Partials      527      561      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 83fa14e into MudBlazor:dev Oct 12, 2024
@ScarletKuro ScarletKuro deleted the dialog_deprecate branch October 12, 2024 11:36
@ScarletKuro ScarletKuro added the v8 label Oct 12, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant