Skip to content

MudTabs: Fix ElementReference regression in #9889#9970

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:tabs_fix
Oct 11, 2024
Merged

MudTabs: Fix ElementReference regression in #9889#9970
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:tabs_fix

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 11, 2024

Description

Regression introduced in #9889
Fixes: #9968

How Has This Been Tested?

Manually via https://github.com/ZizWing/MudTabsLayoutRerenderBug

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 11, 2024
@ScarletKuro ScarletKuro merged commit 84d5509 into MudBlazor:dev Oct 11, 2024
@ScarletKuro ScarletKuro deleted the tabs_fix branch October 11, 2024 16:56
@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (28bc599) to head (9d6dc56).
Report is 538 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9970      +/-   ##
==========================================
+ Coverage   89.82%   90.78%   +0.95%     
==========================================
  Files         412      407       -5     
  Lines       11878    12585     +707     
  Branches     2364     2454      +90     
==========================================
+ Hits        10670    11425     +755     
+ Misses        681      598      -83     
- Partials      527      562      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro mentioned this pull request Oct 11, 2024
Closed
4 tasks
ScarletKuro added a commit that referenced this pull request Oct 11, 2024
@ScarletKuro
MudTabs: Fix ElementReference regression in #9889 (#9970)
6952880 
(cherry picked from commit 84d5509)
@seedysoft seedysoft mentioned this pull request Oct 14, 2024
Merged
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
@ScarletKuro @LLauter
MudTabs: Fix ElementReference regression in MudBlazor#9889 (MudBlazor…
09c1326 
…#9970)
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v7.9.0 Breaks MudTabs when rerendering MainLayout during initialization

1 participant

@ScarletKuro