MudTheme: Fix STJ Deserialization & add test#9961
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom Oct 10, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9961 +/- ##
==========================================
+ Coverage 89.82% 90.78% +0.95%
==========================================
Files 412 407 -5
Lines 11878 12584 +706
Branches 2364 2454 +90
==========================================
+ Hits 10670 11424 +754
+ Misses 681 598 -83
- Partials 527 562 +35 ☔ View full report in Codecov by Sentry. |
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up: #9434
In case work is done for #9004, we need a test to ensure we do not break the STJ source generation for
MudTheme.I also didn't realize that, since we are using polymorphism for
BaseTypography, we need to have a special annotation; otherwise, the deserialization will fail.I believe it is generally important for
MudThemeto be serializable, so you can dump it in JSON and then create a different object from it.How Has This Been Tested?
Unit test.
Type of Changes
Checklist
dev).