PopoverService: Remove locking#9938
Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom Oct 8, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9938 +/- ##
==========================================
+ Coverage 89.82% 90.65% +0.82%
==========================================
Files 412 409 -3
Lines 11878 12639 +761
Branches 2364 2466 +102
==========================================
+ Hits 10670 11458 +788
+ Misses 681 616 -65
- Partials 527 565 +38 ☔ View full report in Codecov by Sentry. |
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We received this complaint: #8325 (comment). Even though we haven't received any actual feedback from them yet, I decided to remove the locking mechanism beforehand.
Historically, the locking mechanism was added in this PR: #3963:
I don’t think this is necessary anymore because:
CancellationTokenSourcethat is triggered on disposal, which means that technically all currently running (or future) JS calls should be aborted. This was added in PopoverService: Attemp to fix SemaphoreFullException #8325 to preventSemaphoreFullException, but eventually it should make the locking non required.How Has This Been Tested?
I think only time can show.
The problem can occur only on BSS under specific conditions that it hard to reproduce on localhost.
Type of Changes
Checklist
dev).