Skip to content

MudCharts: Update Namespace, set some classes visibility to internal#9919

Merged
ScarletKuro merged 13 commits intoMudBlazor:devfrom
ingkor:chartv8
Oct 13, 2024
Merged

MudCharts: Update Namespace, set some classes visibility to internal#9919
ScarletKuro merged 13 commits intoMudBlazor:devfrom
ingkor:chartv8

Conversation

@ingkor
Copy link
Contributor

@ingkor ingkor commented Oct 6, 2024 •
edited by ScarletKuro
Loading

MudCharts Changes (WIP)

Resolves #9910

I implemented the 3 comments of @henon and @ScarletKuro of issue #9910 & #9907

  • Removed MudBlazor.Charts namespace for the MudChart, MudChartBase and the related classes.
  • Files with multiple classes in split up
  • Interpolate methods and classes made internal

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 6, 2024
@codecov
Copy link

codecov bot commented Oct 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.49020% with 25 lines in your changes missing coverage. Please review.

Project coverage is 90.94%. Comparing base (28bc599) to head (fbf0463).
Report is 565 commits behind head on dev.

Files with missing lines Patch % Lines
...zor/Components/Chart/Interpolation/MatrixSolver.cs 53.33% 11 Missing and 3 partials ⚠️
src/MudBlazor/Components/Chart/MudChartBase.cs 75.00% 4 Missing and 1 partial ⚠️
...r/Components/Chart/Interpolation/EndSlopeSpline.cs 87.50% 1 Missing and 1 partial ⚠️
...or/Components/Chart/Interpolation/NaturalSpline.cs 86.66% 1 Missing and 1 partial ⚠️
...r/Components/Chart/Interpolation/PeriodicSpline.cs 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9919      +/-   ##
==========================================
+ Coverage   89.82%   90.94%   +1.11%     
==========================================
  Files         412      409       -3     
  Lines       11878    12528     +650     
  Branches     2364     2446      +82     
==========================================
+ Hits        10670    11394     +724     
+ Misses        681      579     -102     
- Partials      527      555      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Oct 8, 2024 •
edited
Loading

Sorry, but can you adjust the PR according the latest comment: #9910 (comment)

@ingkor
Copy link
Contributor Author

ingkor commented Oct 9, 2024

I adjusted the PR to your comment. Please advice if there is something else I should do (:

@ScarletKuro
Copy link
Member

ScarletKuro commented Oct 10, 2024

Looking good so far.
Will comeback to it later once v8 is started.

@ScarletKuro ScarletKuro added the v8 label Oct 10, 2024
@henon henon added the hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions label Oct 10, 2024
@ingkor
Copy link
Contributor Author

ingkor commented Oct 10, 2024

I'll look into the other chart issues when (if) I have some time free.

ScarletKuro
ScarletKuro approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I will later double check it in my IDE an merge it.

@ScarletKuro ScarletKuro self-assigned this Oct 11, 2024
@ScarletKuro
Copy link
Member

ScarletKuro commented Oct 13, 2024

Moved Filters and Legend to MudBlazor.Charts, ideally this components shouldn't be used by end user and should be internal, but that's not possible in blazor, so moving them away from the sigh, and they have also common name.

@ScarletKuro ScarletKuro changed the title MudCharts V8.0 MudCharts: Update Namespace, set some classes visibility to internal Oct 13, 2024
@ScarletKuro ScarletKuro added breaking change This change will require consumer code updates and removed bug Unexpected behavior or functionality not working as intended labels Oct 13, 2024
@ScarletKuro ScarletKuro mentioned this pull request Oct 13, 2024
Merged
7 tasks
@ScarletKuro ScarletKuro mentioned this pull request Oct 13, 2024
Closed
@ScarletKuro
Copy link
Member

ScarletKuro commented Oct 13, 2024

Added to v8.0.0 Migration Guide #9953

@ScarletKuro ScarletKuro merged commit 651f595 into MudBlazor:dev Oct 13, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
@ingkor @LLauter
MudCharts: Update Namespace, set some classes visibility to internal (M…
fbdeea3 
…udBlazor#9919)
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Closed
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Closed
This was referenced Oct 5, 2025
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Nov 3, 2025
Merged
@dependabot dependabot bot mentioned this pull request Nov 12, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jan 3, 2026
Closed
@dependabot dependabot bot mentioned this pull request Jan 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

Assignees

@ScarletKuro ScarletKuro

Labels

breaking change This change will require consumer code updates hacktoberfest Hacktoberfest 2021 hacktoberfest2024 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chart changes for v8

3 participants

@ingkor @ScarletKuro @henon