Skip to content

MudDataGrid: Fix NRE when property has a nested null value#9916

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:datagrid_readnull
Oct 6, 2024
Merged

MudDataGrid: Fix NRE when property has a nested null value#9916
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:datagrid_readnull

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Oct 5, 2024

Description

Fixes: #6788

How Has This Been Tested?

Added bUnit test + checked manually.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 5, 2024
@ScarletKuro ScarletKuro changed the title MudDataGrid: Fix NullReferenceException when property has a nested null value MudDataGrid: Fix NRE when property has a nested null value Oct 5, 2024
@codecov
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (28bc599) to head (e4943ce).
Report is 509 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9916      +/-   ##
==========================================
+ Coverage   89.82%   90.84%   +1.01%     
==========================================
  Files         412      412              
  Lines       11878    12864     +986     
  Branches     2364     2487     +123     
==========================================
+ Hits        10670    11686    +1016     
+ Misses        681      616      -65     
- Partials      527      562      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro added the hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions label Oct 6, 2024
@ScarletKuro ScarletKuro merged commit b3df337 into MudBlazor:dev Oct 6, 2024
@ScarletKuro ScarletKuro deleted the datagrid_readnull branch October 6, 2024 10:39
ingkor pushed a commit to ingkor/MudBlazor that referenced this pull request Oct 6, 2024
ScarletKuro added a commit to ScarletKuro/MudBlazor that referenced this pull request Oct 16, 2024
ScarletKuro added a commit to ScarletKuro/MudBlazor that referenced this pull request Oct 16, 2024
ScarletKuro added a commit that referenced this pull request Oct 17, 2024
# Conflicts:
#	src/MudBlazor.UnitTests/Components/DataGridTests.cs
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended hacktoberfest Hacktoberfest 2021 hacktoberfest2024 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDataGrid NullReferenceException when Property's value is null

2 participants