Skip to content

MudAutocomplete: Incorrect horizontal spacing on RTL mode#9913

Merged
henon merged 3 commits intoMudBlazor:devfrom
ralvarezing:bugfix/autocomplete-incorrect-spinner-spacing
Oct 7, 2024
Merged

MudAutocomplete: Incorrect horizontal spacing on RTL mode#9913
henon merged 3 commits intoMudBlazor:devfrom
ralvarezing:bugfix/autocomplete-incorrect-spinner-spacing

Conversation

@ralvarezing
Copy link
Member

@ralvarezing ralvarezing commented Oct 5, 2024

Description

MudAutocomplete component had incorrect spacing when loading and on RTL mode.
This includes a specific css styles to take in consideration both cases (LTR and RTL modes).

image
image

fixes #9880

How Has This Been Tested?

Visually tested on the Docs project.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added the bug Unexpected behavior or functionality not working as intended label Oct 5, 2024
@ralvarezing
Copy link
Member Author

@henon @danielchalmers is this spacing intentional?
image

What do you think on removing it so it fills the space used by the adornamet (that is not visible when loading)?

@codecov
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (28bc599) to head (b14d6ed).
Report is 514 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9913      +/-   ##
==========================================
+ Coverage   89.82%   90.85%   +1.03%     
==========================================
  Files         412      415       +3     
  Lines       11878    12954    +1076     
  Branches     2364     2509     +145     
==========================================
+ Hits        10670    11770    +1100     
+ Misses        681      618      -63     
- Partials      527      566      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ralvarezing ralvarezing marked this pull request as ready for review October 5, 2024 20:52
@Garderoben Garderoben self-requested a review October 6, 2024 09:53
@Garderoben
Copy link
Member

@henon @danielchalmers is this spacing intentional? image

What do you think on removing it so it fills the space used by the adornamet (that is not visible when loading)?

I think its a fine idea to use the adornment space if none is used.

@henon henon added hacktoberfest Hacktoberfest 2021 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions hacktoberfest2024 labels Oct 6, 2024
@henon
Copy link
Contributor

henon commented Oct 6, 2024

Nice catch on the RTL spacing

@ralvarezing
Copy link
Member Author

@henon @danielchalmers is this spacing intentional? image
What do you think on removing it so it fills the space used by the adornamet (that is not visible when loading)?

I think its a fine idea to use the adornment space if none is used.

@Garderoben ready

@henon henon merged commit 8e3d5da into MudBlazor:dev Oct 7, 2024
@henon
Copy link
Contributor

henon commented Oct 7, 2024

Thanks @ralvarezing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended hacktoberfest Hacktoberfest 2021 hacktoberfest2024 hacktoberfest-accepted Issues and PRs which were accepted as Hacktoberfest submissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudAutocomplete: Wrong padding in Right to Left mode

4 participants