Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (28bc599) to head (d3ea351).
Report is 513 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #9904      +/-   ##
==========================================
+ Coverage   89.82%   90.82%   +0.99%     
==========================================
  Files         412      412              
  Lines       11878    12868     +990     
  Branches     2364     2487     +123     
==========================================
+ Hits        10670    11687    +1017     
+ Misses        681      618      -63     
- Partials      527      563      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Can you post before and after pic?

Before

After

Can you post before and after pic?

This comment made me realize the Switch changes were not right. I removed them.

@ingkor that feels as inconsistent as it did before to me.

I would think the slightly shaded color of the MudSwitch is quite fitting and could be applied to the other controls.

As now the color is the same as when active, so there is no distinction for the user if the Checkbox should be selectable or not.

The hover attribute makes the difference. It doesn't react when it's being hovered in readonly now.

However it might be interesting to use a slightly dimmed color (lighten variant).
As it's being done in switch.

Imo this is 1 stepnin the right direction already.

That does not work on mobile though.

Wouldn't the issue be fixed if the custom color would override the read only color.

That way if no custom color is set it would still have the preset read only color

There was an existing bug in the logic that may cause an additional issue with the colors: #9524 (comment)

So we could do the lighten variant when disabled? Or not?

@ingkor Thanks for your work, Will wait for @Garderoben to weigh in

#hacktoberfest eligibility? :D
I could also make a proposal to show the light colors when it's readonly. However I didn't find a library that did this... In a react example it was the same color.

#hacktoberfest eligibility?

Of course! Thanks for contributing in Hacktober. I'll merge once @danielchalmers approves as well.

Thanks @ingkor !