Skip to content

MudButton: Fix sonar warning about Dispose implementation#9844

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:button_fix_dispose
Sep 21, 2024
Merged

MudButton: Fix sonar warning about Dispose implementation#9844
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:button_fix_dispose

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Sep 21, 2024

Description

Fix warning: https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&types=CODE_SMELL&id=MudBlazor_MudBlazor&open=AZIUPxuZIeA6x4ifP5V-

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Sep 21, 2024
@codecov
Copy link

codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (28bc599) to head (c3d21d8).
Report is 487 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9844      +/-   ##
==========================================
+ Coverage   89.82%   90.82%   +0.99%     
==========================================
  Files         412      406       -6     
  Lines       11878    12823     +945     
  Branches     2364     2483     +119     
==========================================
+ Hits        10670    11646     +976     
+ Misses        681      623      -58     
- Partials      527      554      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 722c500 into MudBlazor:dev Sep 21, 2024
@ScarletKuro ScarletKuro deleted the button_fix_dispose branch September 21, 2024 11:19
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScarletKuro