Skip to content

MudButton : Implement IDisposable#9835

Merged
henon merged 3 commits intoMudBlazor:devfrom
vernou:fix-pr-9713
Sep 21, 2024
Merged

MudButton : Implement IDisposable#9835
henon merged 3 commits intoMudBlazor:devfrom
vernou:fix-pr-9713

Conversation

@vernou
Copy link
Member

@vernou vernou commented Sep 18, 2024

Description

In the PR #9713, the method MudButton.Dispose was added. But MudButton don't implement IDisposable, so MudButton.Dispose isn't called.

How Has This Been Tested?

I added unit test.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added the bug Unexpected behavior or functionality not working as intended label Sep 18, 2024
@codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (28bc599) to head (b929458).
Report is 486 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9835      +/-   ##
==========================================
+ Coverage   89.82%   90.79%   +0.96%     
==========================================
  Files         412      406       -6     
  Lines       11878    12819     +941     
  Branches     2364     2482     +118     
==========================================
+ Hits        10670    11639     +969     
+ Misses        681      625      -56     
- Partials      527      555      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Sep 19, 2024

Is this still a draft?

@vernou
Copy link
Member Author

vernou commented Sep 19, 2024 •
edited
Loading

@ScarletKuro Yes, again a little refactoring. I will finish tonight.

@vernou vernou marked this pull request as ready for review September 19, 2024 19:51
@vernou
Copy link
Member Author

vernou commented Sep 19, 2024

@ScarletKuro The PR is ready to review.

@ScarletKuro ScarletKuro requested a review from henon September 19, 2024 19:57
@henon henon merged commit a060f5e into MudBlazor:dev Sep 21, 2024
@vernou vernou deleted the fix-pr-9713 branch September 22, 2024 12:14
@vernou vernou self-assigned this Nov 18, 2024
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

@henon henon Awaiting requested review from henon

Assignees

@vernou vernou

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vernou @ScarletKuro @henon