MudDataGrid: properly clear the filter values#9801
Merged
ScarletKuro merged 4 commits intoMudBlazor:devfrom Sep 23, 2024
Merged
MudDataGrid: properly clear the filter values#9801ScarletKuro merged 4 commits intoMudBlazor:devfrom
ScarletKuro merged 4 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9801 +/- ##
==========================================
+ Coverage 89.82% 90.82% +0.99%
==========================================
Files 412 406 -6
Lines 11878 12825 +947
Branches 2364 2485 +121
==========================================
+ Hits 10670 11648 +978
+ Misses 681 625 -56
- Partials 527 552 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0xced
changed the title
Member
|
Will merge this if @tjscience won't reply within a week on this PR |
tjscience
approved these changes
Sep 22, 2024
Contributor
tjscience
left a comment
tjscience
left a comment
There was a problem hiding this comment.
This looks good to me, although the line with Debug.Assert(index != 1); seems unnecessary.
Contributor
Author
|
Removed in 3099416. |
Member
|
The
|
4 tasks
ScarletKuro
added a commit
to ScarletKuro/MudBlazor
that referenced
this pull request
Oct 16, 2024
7 tasks
ScarletKuro
added a commit
that referenced
this pull request
Oct 17, 2024
ScarletKuro
added a commit
that referenced
this pull request
Oct 17, 2024
|
This appears to still exist if you are running on .NET 8 in pure server mode and using ServerData to populate? The clear button does force the grid to refresh, but the filters do not get cleared. |
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clicking the clear filter buttons or calling the
dataGrid.ClearFiltersAsync()method would not actually clear the filter values.Fixes #6951
Fixes #8318
Closes #9532
How Has This Been Tested?
Two unit tests have been added.
Type of Changes
Before (❌ filter values don't clear):
Before.mp4
After (✅ filter values are properly cleared):
After.mp4
Checklist
dev).