ToggleGroup: Fix bad layout on initial render#9706
Merged
henon merged 1 commit intoMudBlazor:devfrom Aug 24, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9706 +/- ##
==========================================
+ Coverage 89.82% 90.78% +0.95%
==========================================
Files 412 406 -6
Lines 11878 12801 +923
Branches 2364 2474 +110
==========================================
+ Hits 10670 11622 +952
+ Misses 681 624 -57
- Partials 527 555 +28 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
Aug 24, 2024
Member
|
Thanks for fixing it. That visual flick was annoying. |
Contributor
|
Epic change ;) |
7 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When registering the toggle item children, it now marks the state as changed so that the
Stylenameproperty will pick up the new columns/rows.How Has This Been Tested?
visually
Type of Changes
Before, on first render you would see this:
followed by:
now it correctly looks like this from the start:
Checklist
dev).