MudField: Text overflow ellipsis for labels#9613
Merged
henon merged 2 commits intoMudBlazor:devfrom Aug 21, 2024
Merged
Conversation
github-actions
bot
added
bug
ArcadeMode
force-pushed
the
9574-field-label-overflow
branch
from
6555707 to
f60461a
Compare
ArcadeMode
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9613 +/- ##
==========================================
+ Coverage 89.82% 90.57% +0.74%
==========================================
Files 412 406 -6
Lines 11878 12751 +873
Branches 2364 2472 +108
==========================================
+ Hits 10670 11549 +879
+ Misses 681 641 -40
- Partials 527 561 +34 ☔ View full report in Codecov by Sentry. |
danielchalmers
approved these changes
Aug 21, 2024
henon
added
enhancement
henon
changed the title
Contributor
|
Thanks! |
Contributor
|
Nice tweak! We had already applied a no-wrap style for this very reason. Just a suggestion to maybe list things like this as a breaking change in the release notes in the future. I can anticipate apps where ellipses start appearing for long labels that may have already been styled to assume they will wrap as they did in the past. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #9574
As proposed in #9574, field label styles to prevent text overflow and text wrap. instead does ellipsis. Tested locally and seems to work okay.
Before:
After:
How Has This Been Tested?
Visually tested on different docs pages.
Type of Changes
Checklist
dev).