Skip to content

MudGlobal: Remove EnableIllegalRazorParameterDetection#9580

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
danielchalmers:global-illegal-parameter-obsolete
Oct 10, 2024
Merged

MudGlobal: Remove EnableIllegalRazorParameterDetection#9580
ScarletKuro merged 1 commit intoMudBlazor:devfrom
danielchalmers:global-illegal-parameter-obsolete

Conversation

@danielchalmers
Copy link
Member

Description

Removes a functionless parameter.

This could be merged in v7 to ensure no one uses it by accident, or saved for v8 for strict SemVer adherence.

How Has This Been Tested?

none

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers requested a review from henon August 7, 2024 15:45
@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Aug 7, 2024
@codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (28bc599) to head (c56ecbc).
Report is 532 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9580      +/-   ##
==========================================
+ Coverage   89.82%   90.56%   +0.73%     
==========================================
  Files         412      406       -6     
  Lines       11878    12748     +870     
  Branches     2364     2472     +108     
==========================================
+ Hits        10670    11545     +875     
+ Misses        681      641      -40     
- Partials      527      562      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon
Copy link
Contributor

henon commented Aug 7, 2024

It is an oversight. Nonetheless it doesn't hurt anybody, so I guess we can wait for v8 with this.

@henon henon added v8 and removed PR: needs review labels Aug 7, 2024
@ScarletKuro ScarletKuro added refactor Reorganizes code and has no changes to the API or functionality in the main library API change Modifies the public API surface labels Aug 8, 2024
@danielchalmers danielchalmers changed the title MudGlobal: Delete obsolete EnableIllegalRazorParameterDetection MudGlobal: Remove MudGlobal.EnableIllegalRazorParameterDetection Sep 23, 2024
@danielchalmers danielchalmers changed the title MudGlobal: Remove MudGlobal.EnableIllegalRazorParameterDetection MudGlobal: Remove EnableIllegalRazorParameterDetection Sep 23, 2024
@ScarletKuro ScarletKuro merged commit 49c6301 into MudBlazor:dev Oct 10, 2024
@ScarletKuro
Copy link
Member

Added to v8.0.0 Migration Guide #9953

LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates refactor Reorganizes code and has no changes to the API or functionality in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants