MudText: Handle empty HtmlTag as null#9576
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom Aug 7, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9576 +/- ##
==========================================
+ Coverage 89.82% 90.58% +0.75%
==========================================
Files 412 406 -6
Lines 11878 12749 +871
Branches 2364 2472 +108
==========================================
+ Hits 10670 11549 +879
+ Misses 681 640 -41
- Partials 527 560 +33 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9575.
Avoids a simple pitfall where someone sets
HtmlTag=""and expects it to be the same as not defining it at all.We let whitespace fail (
HtmlTag=" ") because that is a distinct value and is unlikely to be accidentally added.How Has This Been Tested?
unit
Type of Changes
Checklist
dev).