Skip to content

Localization: Make InternalMudLocalizer implement IStringLocalizer#9527

Merged
ScarletKuro merged 4 commits intoMudBlazor:devfrom
ScarletKuro:localizationstring
Jul 29, 2024
Merged

Localization: Make InternalMudLocalizer implement IStringLocalizer#9527
ScarletKuro merged 4 commits intoMudBlazor:devfrom
ScarletKuro:localizationstring

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Jul 29, 2024

Description

Required for this PR: #8581

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro added the localization Translations, locale formats, RTL layout, calendars label Jul 29, 2024
@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Jul 29, 2024
@codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (28bc599) to head (3102661).
Report is 391 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9527      +/-   ##
==========================================
+ Coverage   89.82%   90.58%   +0.75%     
==========================================
  Files         412      407       -5     
  Lines       11878    12729     +851     
  Branches     2364     2467     +103     
==========================================
+ Hits        10670    11530     +860     
+ Misses        681      639      -42     
- Partials      527      560      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EmilAlipiev

This comment was marked as off-topic.

@ScarletKuro

This comment was marked as off-topic.

@EmilAlipiev

This comment was marked as off-topic.

@ScarletKuro
Copy link
Member Author

Normally if you dont use Localization, you dont need to set Services.AddMudLocalization(); this change makes is compulsory.

However, this has nothing to do with this particular PR. The need for InternalMudLocalizer was introduced in PR #7024, which was already in v6. I explained in detail in these two posts: #8581 (comment).

In short, you just got lucky in v6 by not encountering a component that required InternalMudLocalizer, but now in v7, as more components started utilizing it internally, you hit the problem. However, the necessity for it was established back in mid-2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library localization Translations, locale formats, RTL layout, calendars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants