Skip to content

MudDrawer: Add OverlayAutoClose, use OnClosed instead of OnClick#9500

Merged
henon merged 1 commit intoMudBlazor:devfrom
ScarletKuro:drawer_fix
Jul 25, 2024
Merged

MudDrawer: Add OverlayAutoClose, use OnClosed instead of OnClick#9500
henon merged 1 commit intoMudBlazor:devfrom
ScarletKuro:drawer_fix

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Jul 25, 2024

Description

Makes corresponding changes after: #9458
Addresses: #9491

How Has This Been Tested?

Visually, bUnit

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Jul 25, 2024
@ScarletKuro ScarletKuro requested a review from henon July 25, 2024 14:20
@codecov
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (28bc599) to head (fe14d5b).
Report is 382 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9500      +/-   ##
==========================================
+ Coverage   89.82%   90.56%   +0.73%     
==========================================
  Files         412      406       -6     
  Lines       11878    12708     +830     
  Branches     2364     2462      +98     
==========================================
+ Hits        10670    11509     +839     
+ Misses        681      638      -43     
- Partials      527      561      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 2ad7b78 into MudBlazor:dev Jul 25, 2024
@ScarletKuro ScarletKuro deleted the drawer_fix branch July 25, 2024 17:59
@seedysoft seedysoft mentioned this pull request Aug 1, 2024
Merged
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielchalmers danielchalmers danielchalmers approved these changes

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ScarletKuro @danielchalmers @henon