Performance: Add more extension methods for Array and List#9487
Merged
henon merged 4 commits intoMudBlazor:devfrom Jul 24, 2024
xC0dex:performance/collection-extensions
Merged
Performance: Add more extension methods for Array and List#9487henon merged 4 commits intoMudBlazor:devfrom xC0dex:performance/collection-extensions
henon merged 4 commits intoMudBlazor:devfrom
xC0dex:performance/collection-extensions
Conversation
xC0dex
added
the
performance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9487 +/- ##
==========================================
+ Coverage 89.82% 90.55% +0.72%
==========================================
Files 412 406 -6
Lines 11878 12718 +840
Branches 2364 2462 +98
==========================================
+ Hits 10670 11517 +847
+ Misses 681 639 -42
- Partials 527 562 +35 ☔ View full report in Codecov by Sentry. |
henon
approved these changes
Jul 23, 2024
henon
changed the title
Member
|
@henon I feel like it would be still nice to have some dedicated unit tests for this even if those are simple one liners, what do you think? |
Member
Author
No problem, I could add tests for each method if you want 👍 |
ScarletKuro
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an addition to #9461
I added some more extension methods and updated a private field and a private property to use
Listinstead ofIListto make use of the new extension methods.How Has This Been Tested?
Existing unit tests.
Checklist
dev).