TableGrid: Fix RowsPerPage firing ServerData twice#9463
Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom Jul 20, 2024
Merged
TableGrid: Fix RowsPerPage firing ServerData twice#9463ScarletKuro merged 3 commits intoMudBlazor:devfrom
ScarletKuro merged 3 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
Member
|
I only see the changes to the tests, did you forgot to push changes for MudTable? |
Member
Author
|
Just out of habit, first commit to demonstrate the bug with a test that fail and a second to fix it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9463 +/- ##
==========================================
+ Coverage 89.82% 90.57% +0.74%
==========================================
Files 412 405 -7
Lines 11878 12713 +835
Branches 2364 2462 +98
==========================================
+ Hits 10670 11515 +845
+ Misses 681 638 -43
- Partials 527 560 +33 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@ScarletKuro, can you review this PR? |
ScarletKuro
approved these changes
Jul 20, 2024
ScarletKuro
approved these changes
Jul 20, 2024
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when
MudTable.RowsPerPageis modified,MudTable.ServerDatais called two time.First because
MudTable.CurrentPageis reset to 0.Second because
MudTable.RowsPerPageis modified.This PR modify this behavior to call only one time
MudTable.ServerDatawhenMudTable.RowsPerPageis modified.The modification is
MudTable.RowsPerPagereset the fieldMudTable._currentPageto 0 instead of the property.Fixes #8298
Similar to #9448
How Has This Been Tested?
I added a test to reproduce the bug.
Type of Changes
Checklist
dev).