Skip to content

MudTreeView: Don't select on expand button double click#9428

Merged
ScarletKuro merged 8 commits intoMudBlazor:devfrom
henon:treeview-doubleclick-fix
Jul 17, 2024
Merged

MudTreeView: Don't select on expand button double click#9428
ScarletKuro merged 8 commits intoMudBlazor:devfrom
henon:treeview-doubleclick-fix

Conversation

@henon
Copy link
Contributor

@henon henon commented Jul 17, 2024

Description

Resolves #9419

  • When expanding/collapsing via the expand button don't select on double click by preventing its propagation
  • Split MudTreeViewItemToggleButton into code and razor files
  • MudTreeViewItemToggleButton inherits MudComponentBase now
  • MudTreeViewItemToggleButton forwards Class and Style as well as UserAttributes to inner icon button

How Has This Been Tested?

unit

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jul 17, 2024
@ingkor
Copy link
Contributor

ingkor commented Jul 17, 2024

Damn it too late, I found it out and solved it as well but was looking to add some tests after work.

@henon
Copy link
Contributor Author

henon commented Jul 17, 2024

Great @ingkor thanks for being the kind of person who cares about the library and PRs fixes! I am working on tests right now

@codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.56%. Comparing base (28bc599) to head (7a5468a).
Report is 355 commits behind head on dev.

Files Patch % Lines
...ponents/TreeView/MudTreeViewItemToggleButton.razor 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9428      +/-   ##
==========================================
+ Coverage   89.82%   90.56%   +0.73%     
==========================================
  Files         412      404       -8     
  Lines       11878    12696     +818     
  Branches     2364     2460      +96     
==========================================
+ Hits        10670    11498     +828     
+ Misses        681      636      -45     
- Partials      527      562      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon
Copy link
Contributor Author

henon commented Jul 17, 2024

Ready @ScarletKuro

@ScarletKuro ScarletKuro merged commit 98476b1 into MudBlazor:dev Jul 17, 2024
@ScarletKuro
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudTreeview: Multi-Selection bug on Expand/Collapse

3 participants