MudField, MudMask: Support typography customization#9421
Merged
henon merged 1 commit intoMudBlazor:devfrom Jul 17, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9421 +/- ##
==========================================
+ Coverage 89.82% 90.60% +0.77%
==========================================
Files 412 403 -9
Lines 11878 12675 +797
Branches 2364 2452 +88
==========================================
+ Hits 10670 11484 +814
+ Misses 681 632 -49
- Partials 527 559 +32 ☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks! |
Contributor
|
Easy thing to miss; inheritance is such a fickle mistress. ;) This has fixed our sizing issues with both MudField and Mask. Thanks so much for the quick fix @danielchalmers! |
Member
Author
|
@gabephudson No problem, it was a lot easier thanks to your detailed comment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follows up on #8754 and Resolves #9412, also reported in #8754 (comment).
MudField and MudMask are not using a standard inheritance so were missed in the original PR. This brings parity for the application of typography classes to them.
How Has This Been Tested?
visually
Type of Changes
Checklist
dev).