Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.59%. Comparing base (28bc599) to head (fbfa7fb).
Report is 346 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #9386      +/-   ##
==========================================
+ Coverage   89.82%   90.59%   +0.76%     
==========================================
  Files         412      403       -9     
  Lines       11878    12669     +791     
  Branches     2364     2448      +84     
==========================================
+ Hits        10670    11478     +808     
+ Misses        681      632      -49     
- Partials      527      559      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Before I merge it, do we need any notes on little behavior change for migration guide or not or we just consider it as bug fix?

I'd argue this is a bug fix. However I suggested a clarification note in the docs of EditForm #9215 (comment)

Thanks!

Will this fix an issue we're seeing with Mud input components that have Required=true within an EditForm (not MudForm) with a custom validator? Anything with required=true pops up a validation error rather than running our own fluent validator which does more conditional validation (and could skip required fields in certain instances)?

Will this fix an issue we're seeing

I would say the best thing is to try it out. It's part of MudBlazor starting from version 7.2.0.

Hmm, didn't realise it was already in release, in which case, it does not. I'll need to raise a bug.

Mud input components that have Required=true within an EditForm (not MudForm) with a custom validator? Anything with required=true pops up a validation error rather than running our own fluent validator which does more conditional validation (and could skip required fields in certain instances)?

I don't think it will, based on my knowledge. When you set Require, it adds a required attribute to the underlying native HTML inputs. When used in conjunction with a form, the default HTML browser validation will be triggered, and this validation will always dominate, as in this case: #9409 (comment). Unfortunately, I don't know if this validation can be suppressed.

Hmm, didn't realise it was already in release, in which case, it does not. I'll need to raise a bug.

Not sure if it's even possible to fix tho.

I think you can try to add the novalidate attribute to the EditForm

I think you can try to add the novalidate attribute to the EditForm

OK, I guess with v7, MudBlazor adds the required HTML tag where previously it didn't (and just appended * to the label to denote required). Looks like adding the novalidate overrides the native handing of required. Thanks for the help!