MudPicker: Add OverflowBehavior that is passed to the underlying MudPopover#9372
Merged
henon merged 1 commit intoMudBlazor:devfrom Jul 13, 2024
Merged
MudPicker: Add OverflowBehavior that is passed to the underlying MudPopover#9372henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
…sed to the underlying MudPopover
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9372 +/- ##
==========================================
+ Coverage 89.82% 90.61% +0.78%
==========================================
Files 412 403 -9
Lines 11878 12668 +790
Branches 2364 2448 +84
==========================================
+ Hits 10670 11479 +809
+ Misses 681 634 -47
- Partials 527 555 +28 ☔ View full report in Codecov by Sentry. |
danielchalmers
approved these changes
Jul 11, 2024
henon
changed the title
henon
changed the title
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a single
[Parameter]property to theMudPickercomponent inMudPicker.razor.csthat defaults toOverflowBehavior.FlipOnOpenand is simply passed to the underlyingMudPopovercomponent inMudPicker.razorwhere it was previously just always passingOverflowBehavior.FlipOnOpen.Description
resolves #9371
How Has This Been Tested?
Tested visually by fiddling with the values passed to the examples on the locally hosted docs site. All existing unit tests pass, and the changes are very minimal and make use of existing behaviour in
MudPopoverso I don't think additional unit tests are necessary.Type of Changes
Checklist
dev).