Skip to content

Hook up Autocomplete.MaxLength#9364

Merged
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:autocomplete-maxlength
Jul 13, 2024
Merged

Hook up Autocomplete.MaxLength#9364
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:autocomplete-maxlength

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Jul 10, 2024

Description

Fixes #3928 - property was simply not hooked up which made it useless

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jul 10, 2024
@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.62%. Comparing base (28bc599) to head (462af00).
Report is 335 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9364      +/-   ##
==========================================
+ Coverage   89.82%   90.62%   +0.79%     
==========================================
  Files         412      403       -9     
  Lines       11878    12667     +789     
  Branches     2364     2448      +84     
==========================================
+ Hits        10670    11480     +810     
+ Misses        681      633      -48     
- Partials      527      554      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 9c39dee into MudBlazor:dev Jul 13, 2024
@henon
Copy link
Contributor

henon commented Jul 13, 2024

Thanks!

danielchalmers added a commit to danielchalmers/CodeBeam.MudBlazor.Extensions that referenced this pull request Aug 15, 2024
@danielchalmers
MudComboBox: Hook up MaxLength
a19e7aa 
MudBlazor/MudBlazor#9364
@danielchalmers danielchalmers mentioned this pull request Aug 15, 2024
Merged
mckaragoz pushed a commit to CodeBeamOrg/CodeBeam.MudBlazor.Extensions that referenced this pull request Sep 2, 2024
@danielchalmers
MudComboBox: Hook up MaxLength (#445)
55fa821 
MudBlazor/MudBlazor#9364
@danielchalmers danielchalmers mentioned this pull request Oct 20, 2024
Closed
2 tasks
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MaxLength Property for MudAutocomplete is ignored

3 participants

@danielchalmers @henon @ScarletKuro