MudAutocomplete: Modify default autocomplete method (#9318)#9354
Merged
henon merged 1 commit intoMudBlazor:devfrom Jul 10, 2024
Merged
MudAutocomplete: Modify default autocomplete method (#9318)#9354henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
Modified: Unit tests to comply with the changes made.
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9354 +/- ##
==========================================
+ Coverage 89.82% 90.76% +0.93%
==========================================
Files 412 403 -9
Lines 11878 12665 +787
Branches 2364 2447 +83
==========================================
+ Hits 10670 11495 +825
+ Misses 681 618 -63
- Partials 527 552 +25 ☔ View full report in Codecov by Sentry. |
Member
|
Looks good. What changed since #959? |
Contributor
Author
Contributor
Chrome possibly didn't respect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new default method for autocompletion to ensure the autocorrect operates as expected on Chrome.
Problem
The existing method of disabling autocomplete by appending a unique identifier to the autocomplete attribute no longer works in Chrome as of 2024. Recent changes in browser behavior have rendered this approach ineffective.
Solution
The problem can be resolved by simply using "off" as the default value for the autocomplete attribute, this solution has been thoroughly tested to ensure compatibility with other browsers.
References
Fixes: #9318
How Has This Been Tested?
Type of Changes
Checklist
dev).