Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9344 +/- ##
==========================================
+ Coverage 89.82% 90.74% +0.91%
==========================================
Files 412 403 -9
Lines 11878 12665 +787
Branches 2364 2447 +83
==========================================
+ Hits 10670 11493 +823
+ Misses 681 619 -62
- Partials 527 553 +26 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Added test case |
Member
Author
|
@henon I hope you don't mind that I referenced |
Contributor
|
I agree. Definitely better than duplicating code. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #9341
Also replacing (where noticed):
with:
Because the first version generates:
which is equivalent to:
This means that
taskcan benulland will lead to an exception. The second version avoids this problem.How Has This Been Tested?
Will add later
Type of Changes
Checklist
dev).