MudBadge: Center content with flex instead of negative margins#9305
Merged
henon merged 1 commit intoMudBlazor:devfrom Jul 5, 2024
Merged
MudBadge: Center content with flex instead of negative margins#9305henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9305 +/- ##
==========================================
+ Coverage 89.82% 90.83% +1.00%
==========================================
Files 412 403 -9
Lines 11878 12566 +688
Branches 2364 2441 +77
==========================================
+ Hits 10670 11414 +744
+ Misses 681 602 -79
- Partials 527 550 +23 ☔ View full report in Codecov by Sentry. |
danielchalmers
approved these changes
Jul 3, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MudBadge component currently uses margins to calculate the proper center position of the icon (or content in general).
When changing the browser zoom the icon inside of the MudBadge has been misplaced due to this calculations.
This PR uses flexbox to center the elements vertically and horizontally without any specific pixel definitions, which is more stable.
It is known that the misalignment is still happening, but according to my current knowledge this is caused by calculations of the positions that might end up being subpixel and browser shifts it to the left or right.
Resolves #9294
How Has This Been Tested?
Issue can be tested on https://mudblazor.com/components/badge#usage page with "Security issues" badge.
Type of Changes
Checklist
dev).