Skip to content

MudCollapse: Fix aria-expanded value#9303

Merged
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:mud-collapse-aria-expanded-value
Jul 4, 2024
Merged

MudCollapse: Fix aria-expanded value#9303
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:mud-collapse-aria-expanded-value

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Jul 3, 2024

Description

Simple change. Was resulting in aria-expanded instead of aria-expanded="true" before. This is how we do it in the rest of the codebase.

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers added the accessibility Accessibility concerns (ARIA, keyboard, focus, screen readers, contrast) label Jul 3, 2024
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jul 3, 2024
@codecov
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (28bc599) to head (1a6901e).
Report is 313 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9303      +/-   ##
==========================================
+ Coverage   89.82%   90.83%   +1.00%     
==========================================
  Files         412      403       -9     
  Lines       11878    12566     +688     
  Branches     2364     2441      +77     
==========================================
+ Hits        10670    11414     +744     
+ Misses        681      602      -79     
- Partials      527      550      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 1ef4215 into MudBlazor:dev Jul 4, 2024
@henon
Copy link
Contributor

henon commented Jul 4, 2024

👍

@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

accessibility Accessibility concerns (ARIA, keyboard, focus, screen readers, contrast) bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielchalmers @henon