Skip to content

MudMessageBox: Add button classes#9293

Merged
henon merged 2 commits intoMudBlazor:devfrom
danielchalmers:mud-message-box-button-class-names
Jul 3, 2024
Merged

MudMessageBox: Add button classes#9293
henon merged 2 commits intoMudBlazor:devfrom
danielchalmers:mud-message-box-button-class-names

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Jul 2, 2024

Description

I want class names so I can precisely target them in tests.

How Has This Been Tested?

unit

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers
Copy link
Member Author

danielchalmers commented Jul 2, 2024

How do you feel about the BEM naming style?

@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Jul 2, 2024
@codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (28bc599) to head (5c0773f).
Report is 313 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9293      +/-   ##
==========================================
+ Coverage   89.82%   90.85%   +1.02%     
==========================================
  Files         412      403       -9     
  Lines       11878    12566     +688     
  Branches     2364     2441      +77     
==========================================
+ Hits        10670    11417     +747     
+ Misses        681      601      -80     
- Partials      527      548      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon
Copy link
Contributor

henon commented Jul 3, 2024

Looks good. What does BEM stand for?

@danielchalmers
Copy link
Member Author

danielchalmers commented Jul 3, 2024

Looks good. What does BEM stand for?

@henon See here https://getbem.com/naming/

@henon henon merged commit 952e620 into MudBlazor:dev Jul 3, 2024
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro Awaiting requested review from ScarletKuro

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielchalmers @henon @ScarletKuro