Skip to content

MudBaseInput: Add protected InputElementId (#9277)#9278

Merged
henon merged 2 commits intoMudBlazor:devfrom
igotinfected:feature/mudbaseinput-provide-protected-input-id
Jul 1, 2024
Merged

MudBaseInput: Add protected InputElementId (#9277)#9278
henon merged 2 commits intoMudBlazor:devfrom
igotinfected:feature/mudbaseinput-provide-protected-input-id

Conversation

@igotinfected
Copy link
Member

@igotinfected igotinfected commented Jun 29, 2024

Description

Resolves #9277.

Make InputIdState private and add a protected InternalInputId value to be used in inheritors (as well as custom user components).

How Has This Been Tested?

Existing unit tests.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@igotinfected igotinfected requested a review from ScarletKuro June 29, 2024 17:31
@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Jun 29, 2024
@codecov
Copy link

codecov bot commented Jun 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (28bc599) to head (8f82532).
Report is 310 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9278      +/-   ##
==========================================
+ Coverage   89.82%   90.83%   +1.00%     
==========================================
  Files         412      403       -9     
  Lines       11878    12566     +688     
  Branches     2364     2441      +77     
==========================================
+ Hits        10670    11414     +744     
+ Misses        681      602      -79     
- Partials      527      550      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon June 29, 2024 18:21
@ScarletKuro
Copy link
Member

ScarletKuro commented Jun 29, 2024

@henon adding you in case you want to change the variable name.

@henon
Copy link
Contributor

henon commented Jul 1, 2024

Why not just InputId? The Internal part seems superficial. Or maybe InputElementId

@ScarletKuro
Copy link
Member

ScarletKuro commented Jul 1, 2024

Why not just InputId?

Taken

MudBlazor/src/MudBlazor/Base/MudBaseInput.cs

Lines 421 to 423 in 988f96b

[Parameter]
[Category(CategoryTypes.FormComponent.Behavior)]
public string? InputId { get; set; }

@igotinfected
Copy link
Member Author

igotinfected commented Jul 1, 2024

Went with InputElementId and added comments for clarity, lmk what you think!

@ScarletKuro ScarletKuro changed the title MudBaseInput: Add protected InternalInputId (#9277) MudBaseInput: Add protected InputElementId (#9277) Jul 1, 2024
@henon henon merged commit c20639e into MudBlazor:dev Jul 1, 2024
@igotinfected igotinfected deleted the feature/mudbaseinput-provide-protected-input-id branch July 1, 2024 13:27
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MudBaseInput: make InputId public

3 participants

@igotinfected @ScarletKuro @henon