Skip to content

Fix bug in parameter analyzer#9229

Merged
henon merged 30 commits intoMudBlazor:devfrom
peterthorpe81:feature/unknown-parameter-analyzer
Jun 21, 2024
Merged

Fix bug in parameter analyzer#9229
henon merged 30 commits intoMudBlazor:devfrom
peterthorpe81:feature/unknown-parameter-analyzer

Conversation

@peterthorpe81
Copy link
Contributor

This is an update to pr #9031 to fix #9031 (comment)

It adds the analyzer dll and targets file using an alternative method to avoid the bin directory showing in MudBlazor

Description

How Has This Been Tested?

Tried the analyzer in MudBlazor and Transitively

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jun 21, 2024
@ScarletKuro ScarletKuro requested review from ScarletKuro and henon June 21, 2024 10:43
@henon henon changed the title Feature/unknown parameter analyzer - Bug Fix Fix bug in parameter analyzer Jun 21, 2024
@henon
Copy link
Contributor

henon commented Jun 21, 2024

This PR looks funny. I guess you did not pull dev before starting a new branch or maybe even reused the old PR branch? It won't make a difference when I squash this, it's just a bit confusing and shouldn't happen in future PRs.

@henon henon merged commit 7a85c5c into MudBlazor:dev Jun 21, 2024
@peterthorpe81
Copy link
Contributor Author

This PR looks funny. I guess you did not pull dev before starting a new branch or maybe even reused the old PR branch? It won't make a difference when I squash this, it's just a bit confusing and shouldn't happen in future PRs.

I used the PR branch but won't do that again if it causes an issue. I know it shows 30 commits and then it's just one change but I know you squash them.

@henon
Copy link
Contributor

henon commented Jun 21, 2024

Thanks anyway! Just released this as RC2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants