Skip to content

MudDataGrid: Add correct class to the th element in HeaderCell#9203

Merged
henon merged 1 commit intoMudBlazor:devfrom
Jimmys20:patch-1
Jun 21, 2024
Merged

MudDataGrid: Add correct class to the th element in HeaderCell#9203
henon merged 1 commit intoMudBlazor:devfrom
Jimmys20:patch-1

Conversation

@Jimmys20
Copy link
Contributor

@Jimmys20 Jimmys20 commented Jun 17, 2024

Description

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (28bc599) to head (77f4038).
Report is 282 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9203      +/-   ##
==========================================
+ Coverage   89.82%   90.80%   +0.97%     
==========================================
  Files         412      401      -11     
  Lines       11878    12513     +635     
  Branches     2364     2434      +70     
==========================================
+ Hits        10670    11362     +692     
+ Misses        681      609      -72     
- Partials      527      542      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

Hi, thanks for the PR.
I wonder if there are any visual differences?

@ScarletKuro ScarletKuro added the bug Unexpected behavior or functionality not working as intended label Jun 18, 2024
@Jimmys20
Copy link
Contributor Author

Jimmys20 commented Jun 19, 2024

@ScarletKuro yes, for example the following code:

<Header>
    <tr class="mud-table-row">
        <HeaderCell>test</HeaderCell>
    </tr>
</Header>

produces the following results before and after this change:

before

in the "before" image the padding is wrong and also the bottom border is missing.

@ScarletKuro
Copy link
Member

@ScarletKuro yes, for example the following code:

Thanks, this is what I wanted to see.

@ScarletKuro ScarletKuro requested a review from henon June 19, 2024 11:35
@henon
Copy link
Contributor

henon commented Jun 20, 2024

@Jimmys20 Have you checked if your fix work also works for the reading direction RTL?

@Jimmys20
Copy link
Contributor Author

@henon, has the same result for RTL

Capjture

@henon henon changed the title Add correct class to the th element in HeaderCell.razor MudDataGrid: Add correct class to the th element in HeaderCell Jun 21, 2024
@henon henon merged commit b726b5a into MudBlazor:dev Jun 21, 2024
@henon
Copy link
Contributor

henon commented Jun 21, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants