MudDataGrid: Add correct class to the th element in HeaderCell#9203
Merged
henon merged 1 commit intoMudBlazor:devfrom Jun 21, 2024
Merged
MudDataGrid: Add correct class to the th element in HeaderCell#9203henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9203 +/- ##
==========================================
+ Coverage 89.82% 90.80% +0.97%
==========================================
Files 412 401 -11
Lines 11878 12513 +635
Branches 2364 2434 +70
==========================================
+ Hits 10670 11362 +692
+ Misses 681 609 -72
- Partials 527 542 +15 ☔ View full report in Codecov by Sentry. |
Member
|
Hi, thanks for the PR. |
Contributor
Author
|
@ScarletKuro yes, for example the following code: produces the following results before and after this change: in the "before" image the padding is wrong and also the bottom border is missing. |
ScarletKuro
approved these changes
Jun 19, 2024
Member
Thanks, this is what I wanted to see. |
danielchalmers
approved these changes
Jun 20, 2024
Contributor
|
@Jimmys20 Have you checked if your fix work also works for the reading direction RTL? |
Contributor
Author
|
@henon, has the same result for RTL |
Contributor
|
Thanks |
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Type of Changes
Checklist
dev).