Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (28bc599) to head (7967635).
Report is 265 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #9150      +/-   ##
==========================================
+ Coverage   89.82%   90.67%   +0.84%     
==========================================
  Files         412      400      -12     
  Lines       11878    12510     +632     
  Branches     2364     2436      +72     
==========================================
+ Hits        10670    11343     +673     
+ Misses        681      624      -57     
- Partials      527      543      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi.
Thanks for PR.
Please, add a bUnit test for this case.

Thanks for the test.

Now I'm concerned about the async void you just added. We don't allow that anymore.

Is the InvokeAsync required? If yes, then we should consider breaking the API and make CollapseAllGroups / ExpandAllGroups return a Task and add the Async suffix.

Is the InvokeAsync required?

In my opinion yes - GroupItems() calls StateHasChanged() and need to refresh view after click.

If yes, then we should consider breaking the API and make CollapseAllGroups / ExpandAllGroups return a Task and add the Async suffix.

I am doing it right now.

During test creation I noticed buttons ExpandAll/CollapseAll not working too in this scenario - and they do not working in pasted in issue snippet either - thats why I changed it

Is the InvokeAsync required?

In my opinion yes - GroupItems() calls StateHasChanged() and need to refresh view after click.

In your opinion? I'd rather go with hard facts. Did you test without InvokeAsync and it didn't work?

If I'm not mistaken InvokeAsync is only needed if you are currently not on the render thread, i.e. on a background worker or timer thread or if you are on the render thread but you need to trigger another render for some reason.

If I'm not mistaken InvokeAsync is only needed if you are currently not on the render thread.

That's correct. It should be be always on the UI thread when it comes from OnClick or any other UI interactivity.
I guess it didn't work in test:

await comp.InvokeAsync(() => comp.Instance.CollapseAllGroupsAsync());

should be used.

You're right @henon @ScarletKuro - I rolled back the incorrect changes