DataGrid: Change default values of TemplateColumn#9142
Conversation
|
If this PR gets merged the following default values have changed to Template Column
Select Column
Hierarchy Column (changes inherited from Template column)
|
|
@tjscience last year we talked about this change here: #6049 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9142 +/- ##
==========================================
+ Coverage 89.82% 90.69% +0.86%
==========================================
Files 412 399 -13
Lines 11878 12465 +587
Branches 2364 2427 +63
==========================================
+ Hits 10670 11305 +635
+ Misses 681 623 -58
- Partials 527 537 +10 ☔ View full report in Codecov by Sentry. |
|
@henon @danielchalmers @ScarletKuro ready for review ✌️ |
|
I will let @tjscience to decide, I'm unsure about the |
tjscience
left a comment
There was a problem hiding this comment.
I think everything looks good here. Thanks, @dennisrahmen!
|
@ScarletKuro the "awkward space in footer" was there already and is not even dependent on the I wanted to open a separate pr for that. |
|
@dennisrahmen can you write down all breaking change of that PR for the #8447 |
|
@ScarletKuro @henon I took the hole block so you can just copy paste. |
|
Thanks Dennis |
Description
The
TemplateColumnis generally used to add "Action" columns like editing, select and hierarchy.Currently, the defaults are just the same as for the normal column, which is suboptimal.
In the most common use cases most features are not used or need to be setup first anyway, like with
SortBy.Some of these features like drag and drop add spacing to the column, which is particularly noticeable for select and hierarchy columns.
Furthermore, some features could not been turned off per column, like drag and drop for the hierarchy and select columns.
I also changed the default for 'ShowInFooter' for the SelectColumn since I have seen multiple people complain about the hole row just for the one checkbox.
I would remove that completely to be honest, no other columns support this, and you could always make the header sticky with 'FixedHeader' and have a better experience.
Examples of space savings:

How Has This Been Tested?
visually
Type of Changes
Checklist
dev).